Skip to content

fix typo in localupdate_step for VOMPS algorithm #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 3 commits into from
Apr 16, 2025
Merged

fix typo in localupdate_step for VOMPS algorithm #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f55ff0
fix typo in `localupdate_step` for `VOMPS` algorithm
VictorVanthilt Apr 15, 2025
aaa8060
Switch test to use serial code
lkdvos Apr 15, 2025
a863af8
Fix one more typo
lkdvos Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/algorithms/approximate/vomps.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@
dst_ACs = state.mps isa Multiline ? eachcol(ACs) : ACs

foreach(eachsite) do site
AC = circshift([ac_proj(row, loc, state.mps, state.toapprox, state.envs)
AC = circshift([ac_proj(row, site, state.mps, state.operator, state.envs)

Check warning on line 68 in src/algorithms/approximate/vomps.jl

View check run for this annotation

Codecov / codecov/patch

src/algorithms/approximate/vomps.jl#L68 

Added line #L68 was not covered by tests
for row in 1:size(state.mps, 1)], 1)
C = circshift([c_proj(row, loc, state.mps, state.toapprox, state.envs)
C = circshift([c_proj(row, site, state.mps, state.operator, state.envs)

Check warning on line 70 in src/algorithms/approximate/vomps.jl

View check run for this annotation

Codecov / codecov/patch

src/algorithms/approximate/vomps.jl#L70 

Added line #L70 was not covered by tests
for row in 1:size(state.mps, 1)], 1)
dst_ACs[site] = regauge!(AC, C; alg=alg_orth)
return nothing
Expand Down
3 changes: 3 additions & 0 deletions test/algorithms.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,10 @@ end
W2 = MPSKit.DenseMPO(sW2)

ψ1, _ = approximate(ψ0, (sW1, ψ), VOMPS(; verbosity))
MPSKit.Defaults.set_scheduler!(:serial)
ψ2, _ = approximate(ψ0, (W2, ψ), VOMPS(; verbosity))
MPSKit.Defaults.set_scheduler!()

ψ3, _ = approximate(ψ0, (W1, ψ), IDMRG(; verbosity))
ψ4, _ = approximate(ψ0, (sW2, ψ), IDMRG2(; trscheme=truncdim(12), verbosity))
ψ5, _ = timestep(ψ, H, 0.0, dt, TDVP())
Expand Down
Loading