fix braille and add small test#293
Merged
VictorVanthilt merged 5 commits intomasterfrom May 21, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
lkdvos
reviewed
May 21, 2025
Member
lkdvos
left a comment
There was a problem hiding this comment.
Definitely makes sense to have a separate file, this is a good solution. Maybe it might be reasonable to simply define a operators/show.jl file and move all of this there?
I'm also okay with leaving it as it is now.
Member
Author
|
I moved the abstract mpo show methods, together with braille method to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
braillefunction usable again forMPOHamiltonians, which are no longer consideredSparseMPOs. Additionally it adds some hard-coded tests to ensure is keeps working in the future.I had to add a new file
src/operators/utility.jlwhich isincluded after all the other operator code, to make sure theSparseMPOandMPOHamiltonianstructs are defined before thebraillefunction. If someone comes up with a better solution, please share.