Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report❌ Patch coverage is
... and 77 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Apr 29, 2026
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Looks good to me! I left some minor comments but otherwise I'm happy to merge this and go from there
|
|
||
| function propagator( | ||
| A::AbstractFiniteMPS, z, H::FiniteMPOHamiltonian, | ||
| A::AbstractFiniteMPS, z, H, |
Member
There was a problem hiding this comment.
Suggested change
| A::AbstractFiniteMPS, z, H, | |
| A::AbstractFiniteMPS, z::Number, H, |
Doesnt matter too much but then it is consistent between the two flavors
Comment on lines
+20
to
+21
| left_edge = (interval.start - 1) % length(ham) | ||
| left_ham = InfiniteMPOHamiltonian([ham[i] for i in (left_edge - length(ham) + 1):left_edge]) |
Member
There was a problem hiding this comment.
Suggested change
| left_edge = (interval.start - 1) % length(ham) | |
| left_ham = InfiniteMPOHamiltonian([ham[i] for i in (left_edge - length(ham) + 1):left_edge]) | |
| left_edge = (interval.start - 1) % length(ham) | |
| left_ham = circshift(ham, left_edge) |
Should we just define circshift by itself on hamiltonians? It's probably as easy as InfiniteMPOHamiltonian(circshift(parent(copy(ham)), i))
| right_edge = (interval.stop + 1) % length(ham) | ||
| right_ham = InfiniteMPOHamiltonian([ham[i] for i in right_edge:(right_edge + length(ham) - 1)]) | ||
|
|
||
| finite_ham = FiniteMPOHamiltonian([ham[i] for i in interval]) |
Member
There was a problem hiding this comment.
Suggested change
| finite_ham = FiniteMPOHamiltonian([ham[i] for i in interval]) | |
| finite_ham = FiniteMPOHamiltonian(ham[interval]) |
Does this also work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft pr for a windowhamiltonian type, resolving some pain points from #411
It wasn't possible in the past to correctly create a windowmps environments. The window uses a finitehamiltonian, but then the boundaries require an infinite hamiltonian. This new windowhamiltonian would keep track of the "bath" hamiltonian, and the finite hamiltonian for the window.
Misses full support for the abstractmpo interface, and I think a propagator+window test would be nice to have.