Move gauge fixes back to svd interface

Author: Katharine Hyatt

src/common/gauge.jl

@@ -6,46 +6,3 @@ function gaugefix!(V::AbstractMatrix)
     end
     return V
 end
-
-function gaugefix!(::typeof(svd_full!), U, S, Vᴴ, m::Int, n::Int)
-    for j in 1:max(m, n)
-        if j <= min(m, n)
-            u = view(U, :, j)
-            v = view(Vᴴ, j, :)
-            s = conj(sign(_argmaxabs(u)))
-            u .*= s
-            v .*= conj(s)
-        elseif j <= m
-            u = view(U, :, j)
-            s = conj(sign(_argmaxabs(u)))
-            u .*= s
-        else
-            v = view(Vᴴ, j, :)
-            s = conj(sign(_argmaxabs(v)))
-            v .*= s
-        end
-    end
-    return (U, S, Vᴴ)
-end
-
-function gaugefix!(::typeof(svd_compact!), U, S, Vᴴ, m::Int, n::Int)
-    for j in 1:size(U, 2)
-        u = view(U, :, j)
-        v = view(Vᴴ, j, :)
-        s = conj(sign(_argmaxabs(u)))
-        u .*= s
-        v .*= conj(s)
-    end
-    return (U, S, Vᴴ)
-end
-
-function gaugefix!(::typeof(svd_trunc!), U, S, Vᴴ, m::Int, n::Int)
-    for j in 1:min(m, n)
-        u = view(U, :, j)
-        v = view(Vᴴ, j, :)
-        s = conj(sign(_argmaxabs(u)))
-        u .*= s
-        v .*= conj(s)
-    end
-    return (U, S, Vᴴ)
-end

src/implementations/svd.jl

@@ -66,6 +66,51 @@ function initialize_output(::typeof(svd_trunc!), A::AbstractMatrix, alg::Truncat
     return initialize_output(svd_compact!, A, alg.alg)
 end
 
+function gaugefix!(::typeof(svd_full!), U, S, Vᴴ, m::Int, n::Int)
+    for j in 1:max(m, n)
+        if j <= min(m, n)
+            u = view(U, :, j)
+            v = view(Vᴴ, j, :)
+            s = conj(sign(_argmaxabs(u)))
+            u .*= s
+            v .*= conj(s)
+        elseif j <= m
+            u = view(U, :, j)
+            s = conj(sign(_argmaxabs(u)))
+            u .*= s
+        else
+            v = view(Vᴴ, j, :)
+            s = conj(sign(_argmaxabs(v)))
+            v .*= s
+        end
+    end
+    return (U, S, Vᴴ)
+end
+
+# Gauge fixation 
+# --------------
+function gaugefix!(::typeof(svd_compact!), U, S, Vᴴ, m::Int, n::Int)
+    for j in 1:size(U, 2)
+        u = view(U, :, j)
+        v = view(Vᴴ, j, :)
+        s = conj(sign(_argmaxabs(u)))
+        u .*= s
+        v .*= conj(s)
+    end
+    return (U, S, Vᴴ)
+end
+
+function gaugefix!(::typeof(svd_trunc!), U, S, Vᴴ, m::Int, n::Int)
+    for j in 1:min(m, n)
+        u = view(U, :, j)
+        v = view(Vᴴ, j, :)
+        s = conj(sign(_argmaxabs(u)))
+        u .*= s
+        v .*= conj(s)
+    end
+    return (U, S, Vᴴ)
+end
+
 
 # Implementation
 # --------------