Respond to comments, update AMD SVD tests

Author: kshyatt

Project.toml

@@ -35,6 +35,7 @@ julia = "1.10"
 AMDGPU = "21141c5a-9bdb-4563-92ae-f87d6854732e"
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 ChainRulesTestUtils = "cdddcdb0-9152-4a09-a978-84456f9df70a"
+CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
 JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
 SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
 StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
@@ -47,3 +48,4 @@ test = ["Aqua", "JET", "SafeTestsets", "Test", "TestExtras","ChainRulesCore", "C
 
 [sources]
 AMDGPU = {url = "https://github.com/kshyatt/AMDGPU.jl", rev = "ksh/lrmul"}
+CUDA = {url = "https://github.com/JuliaGPU/CUDA.jl", rev = "master"}

src/common/matrixproperties.jl

@@ -42,7 +42,7 @@ See also [`isisometry`](@ref) and [`is_right_isometry`](@ref).
 """ is_left_isometry
 
 function is_left_isometry(A::AbstractMatrix; isapprox_kwargs...)
-    iszero(min(size(A)...)) && return true
+    iszero(size(A, 2)) && return true
     return isapprox(A' * A, LinearAlgebra.I; isapprox_kwargs...)
 end
 
@@ -56,6 +56,6 @@ See also [`isisometry`](@ref) and [`is_left_isometry`](@ref).
 """ is_right_isometry
 
 function is_right_isometry(A::AbstractMatrix; isapprox_kwargs...)
-    iszero(min(size(A)...)) && return true
+    iszero(size(A, 1)) && return true
     return isapprox(A * A', LinearAlgebra.I; isapprox_kwargs...)
 end

src/implementations/svd.jl

@@ -251,17 +251,16 @@ function _gpu_gesvd_maybe_transpose!(A::AbstractMatrix, S::AbstractVector, U::Ab
     # both CUSOLVER and ROCSOLVER require m ≥ n for gesvd (QR_Iteration)
     # if this condition is not met, do the SVD via adjoint
     minmn = min(m, n)
-    At = min(m, n) > 0 ? adjoint!(similar(A'), A)::AbstractMatrix : similar(A')
-    Ut = similar(U')
-    Vᴴt = similar(Vᴴ')
+    Aᴴ = min(m, n) > 0 ? adjoint!(similar(A'), A)::AbstractMatrix : similar(A')
+    Uᴴ = similar(U')
+    V  = similar(Vᴴ')
     if size(U) == (m, m)
-        _gpu_gesvd!(At, view(S, 1:minmn, 1), Vᴴt, Ut)
+        _gpu_gesvd!(Aᴴ, view(S, 1:minmn, 1), V, Uᴴ)
     else
-        _gpu_gesvd!(At, S, Vᴴt, Ut)
+        _gpu_gesvd!(Aᴴ, S, V, Uᴴ)
     end
-    length(U) > 0 ? adjoint!(U, Ut) : one!(U)
-    length(Vᴴ) > 0 ? adjoint!(Vᴴ, Vᴴt) : one!(Vᴴ)
-    conj!(S)
+    length(U) > 0 && adjoint!(U, Uᴴ)
+    length(Vᴴ) > 0 && adjoint!(Vᴴ, V)
     return U, S, Vᴴ
 end
 

test/amd/svd.jl

@@ -15,7 +15,6 @@ include(joinpath("..", "utilities.jl"))
         k = min(m, n)
         algs = (ROCSOLVER_QRIteration(), ROCSOLVER_Jacobi())
         @testset "algorithm $alg" for alg in algs
-            n > m && alg isa ROCSOLVER_QRIteration && continue # not supported
             minmn = min(m, n)
             A = ROCArray(randn(rng, T, m, n))
 
@@ -51,7 +50,6 @@ end
     @testset "size ($m, $n)" for n in (37, m, 63)
         algs = (ROCSOLVER_QRIteration(), ROCSOLVER_Jacobi())
         @testset "algorithm $alg" for alg in algs
-            n > m && alg isa ROCSOLVER_QRIteration && continue # not supported
             A = ROCArray(randn(rng, T, m, n))
             U, S, Vᴴ = svd_full(A; alg)
             @test U isa ROCMatrix{T} && size(U) == (m, m)