some changes to the ad test utils

Author: Jutho

Project.toml

@@ -34,7 +34,7 @@ Enzyme = "0.13.118"
 EnzymeTestUtils = "0.2.5"
 GenericLinearAlgebra = "0.3.19"
 GenericSchur = "0.5.6"
-JET = "0.9, 0.10"
+JET = "0.9, 0.10, 0.11"
 LinearAlgebra = "1"
 Mooncake = "0.5"
 ParallelTestRunner = "2"

src/pullbacks/svd.jl

@@ -1,4 +1,4 @@
-svd_rank(S, rank_atol) = searchsortedlast(S, rank_atol; rev = true)
+svd_rank(S; rank_atol = default_pullback_rank_atol(S)) = searchsortedlast(S, rank_atol; rev = true)
 
 function check_svd_cotangents(aUΔU, Sr, aVΔV; degeneracy_atol = default_pullback_rank_atol(Sr), gauge_atol = default_pullback_gauge_atol(aUΔU, aVΔV))
     mask = abs.(Sr' .- Sr) .< degeneracy_atol
@@ -43,7 +43,7 @@ function svd_pullback!(
     minmn = min(m, n)
     S = diagview(Smat)
     length(S) == minmn || throw(DimensionMismatch("length of S ($(length(S))) does not matrix minimum dimension of U, Vᴴ ($minmn)"))
-    r = svd_rank(S, rank_atol)
+    r = svd_rank(S; rank_atol)
     Ur = view(U, :, 1:r)
     Vᴴr = view(Vᴴ, 1:r, :)
     Sr = view(S, 1:r)

test/testsuite/TestSuite.jl

@@ -11,7 +11,7 @@ module TestSuite
 using Test
 using MatrixAlgebraKit
 using MatrixAlgebraKit: diagview
-using LinearAlgebra: Diagonal, norm, istriu, istril, I
+using LinearAlgebra: Diagonal, norm, istriu, istril, I, mul!
 using Random, StableRNGs
 using Mooncake
 using AMDGPU, CUDA
@@ -85,9 +85,9 @@ function instantiate_unitary(T, A::ROCMatrix{<:Complex}, sz)
 end
 instantiate_unitary(::Type{<:Diagonal}, A, sz) = Diagonal(fill!(similar(parent(A), eltype(A), sz), one(eltype(A))))
 
-function instantiate_rank_deficient_matrix(T, sz; trunc = trunctol(rtol = 0.5))
+function instantiate_rank_deficient_matrix(T, sz; trunc = truncrank(div(min(sz...), 2)))
     A = instantiate_matrix(T, sz)
-    V, C = left_orth!(A; trunc = trunctol(rtol = 0.5))
+    V, C = left_orth!(A; trunc)
     return mul!(A, V, C)
 end