Skip to content

Commit 1af0718

Browse files
committed
more attempts at improvements
1 parent e4cf3ad commit 1af0718

2 files changed

Lines changed: 5 additions & 13 deletions

File tree

test/orthnull.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ using .TestSuite
1313

1414
is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
1515

16-
m = 54
17-
for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
16+
m = 23
17+
for T in (BLASFloats..., GenericFloats...), n in (17, m, 27)
1818
TestSuite.seed_rng!(123)
1919
if T BLASFloats
2020
if CUDA.functional()

test/svd.jl

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,7 @@ if !is_buildkite
1616
# LAPACK algorithms:
1717
for T in BLASFloats, m in (0, 54), n in (0, 37, m, 63)
1818
TestSuite.seed_rng!(123)
19-
LAPACK_SVD_ALGS = (
20-
LAPACK_QRIteration(),
21-
LAPACK_DivideAndConquer(),
22-
LAPACK_SafeDivideAndConquer(; fixgauge = true),
23-
)
19+
LAPACK_SVD_ALGS = (QRIteration(), DivideAndConquer(), SafeDivideAndConquer(; fixgauge = true))
2420
TestSuite.test_svd(T, (m, n))
2521
TestSuite.test_svd_algs(T, (m, n), LAPACK_SVD_ALGS)
2622
@static if VERSION > v"1.11-" # Jacobi broken on 1.10
@@ -51,11 +47,7 @@ if CUDA.functional()
5147
for T in BLASFloats, m in (0, 23), n in (0, 17, m, 27)
5248
TestSuite.seed_rng!(123)
5349
TestSuite.test_svd(CuMatrix{T}, (m, n))
54-
CUDA_SVD_ALGS = (
55-
CUSOLVER_QRIteration(),
56-
CUSOLVER_SVDPolar(),
57-
CUSOLVER_Jacobi(),
58-
)
50+
CUDA_SVD_ALGS = (QRIteration(), SVDViaPolar(), Jacobi())
5951
TestSuite.test_svd_algs(CuMatrix{T}, (m, n), CUDA_SVD_ALGS)
6052
end
6153

@@ -84,7 +76,7 @@ if AMDGPU.functional()
8476
for T in BLASFloats, m in (0, 23), n in (0, 17, m, 27)
8577
TestSuite.seed_rng!(123)
8678
TestSuite.test_svd(ROCMatrix{T}, (m, n))
87-
AMD_SVD_ALGS = (ROCSOLVER_QRIteration(), ROCSOLVER_Jacobi())
79+
AMD_SVD_ALGS = (QRIteration(), Jacobi())
8880
TestSuite.test_svd_algs(ROCMatrix{T}, (m, n), AMD_SVD_ALGS)
8981
end
9082

0 commit comments

Comments
 (0)