Skip to content

Commit 1f1573c

Browse files
committed
Use internal _rdiv
1 parent c48361d commit 1f1573c

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/pullbacks/qr.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ function qr_pullback!(
8484

8585

8686
Q₁ = view(Q, :, 1:p)
87-
R₁₁ = UpperTriangular(R[1:p, 1:p])
87+
R₁₁ = UpperTriangular(view(R, 1:p, 1:p))
8888
R₁₂ = view(R, 1:p, (p + 1):n)
8989

9090
ΔA₁ = view(ΔA, :, 1:p)
@@ -111,7 +111,8 @@ function qr_pullback!(
111111
Md .= real.(Md)
112112
end
113113
mul!(ΔQ₁, Q₁, M, +1, 1)
114-
ΔA₁ .+= rdiv!(ΔQ₁, R₁₁')
114+
# bypass istriu check
115+
ΔA₁ .+= LinearAlgebra._rdiv!(ΔQ₁, ΔQ₁, R₁₁')
115116
return ΔA
116117
end
117118

0 commit comments

Comments
 (0)