remove unnecessary size arguments

Author: lkdvos

src/common/gauge.jl

@@ -17,7 +17,8 @@ function gaugefix!(V::AbstractMatrix)
     return V
 end
 
-function gaugefix!(::typeof(svd_full!), U, Vᴴ, m::Int, n::Int)
+function gaugefix!(::typeof(svd_full!), U, Vᴴ)
+    m, n = size(U, 1), size(Vᴴ, 2)
     for j in 1:max(m, n)
         if j <= min(m, n)
             u = view(U, :, j)
@@ -38,7 +39,7 @@ function gaugefix!(::typeof(svd_full!), U, Vᴴ, m::Int, n::Int)
     return (U, Vᴴ)
 end
 
-function gaugefix!(::typeof(svd_compact!), U, Vᴴ, m::Int, n::Int)
+function gaugefix!(::typeof(svd_compact!), U, Vᴴ)
     for j in 1:size(U, 2)
         u = view(U, :, j)
         v = view(Vᴴ, j, :)
@@ -49,7 +50,8 @@ function gaugefix!(::typeof(svd_compact!), U, Vᴴ, m::Int, n::Int)
     return (U, Vᴴ)
 end
 
-function gaugefix!(::typeof(svd_trunc!), U, Vᴴ, m::Int, n::Int)
+function gaugefix!(::typeof(svd_trunc!), U, Vᴴ)
+    m, n = size(U, 1), size(Vᴴ, 2)
     for j in 1:min(m, n)
         u = view(U, :, j)
         v = view(Vᴴ, j, :)

src/implementations/svd.jl

@@ -144,7 +144,7 @@ function svd_full!(A::AbstractMatrix, USVᴴ, alg::LAPACK_SVDAlgorithm)
         S[i, 1] = zero(eltype(S))
     end
 
-    dogaugefix && gaugefix!(svd_full!, U, Vᴴ, m, n)
+    dogaugefix && gaugefix!(svd_full!, U, Vᴴ)
 
     return USVᴴ
 end
@@ -174,7 +174,7 @@ function svd_compact!(A::AbstractMatrix, USVᴴ, alg::LAPACK_SVDAlgorithm)
         throw(ArgumentError("Unsupported SVD algorithm"))
     end
 
-    dogaugefix && gaugefix!(svd_compact!, U, Vᴴ, size(A)...)
+    dogaugefix && gaugefix!(svd_compact!, U, Vᴴ)
 
     return USVᴴ
 end
@@ -352,7 +352,7 @@ function svd_full!(A::AbstractMatrix, USVᴴ, alg::GPU_SVDAlgorithm)
     diagview(S) .= view(S, 1:minmn, 1)
     view(S, 2:minmn, 1) .= zero(eltype(S))
 
-    dogaugefix && gaugefix!(svd_full!, U, Vᴴ, m, n)
+    dogaugefix && gaugefix!(svd_full!, U, Vᴴ)
 
     return USVᴴ
 end
@@ -363,7 +363,7 @@ function svd_trunc!(A::AbstractMatrix, USVᴴ, alg::TruncatedAlgorithm{<:GPU_Ran
     _gpu_Xgesvdr!(A, S.diag, U, Vᴴ; alg.alg.kwargs...)
 
     dogaugefix = get(alg.alg.kwargs, :gaugefix, true)::Bool
-    dogaugefix && gaugefix!(svd_trunc!, U, S, Vᴴ, size(A)...)
+    dogaugefix && gaugefix!(svd_trunc!, U, Vᴴ)
 
     # TODO: make sure that truncation is based on maxrank, otherwise this might be wrong
     USVᴴtrunc, ind = truncate(svd_trunc!, (U, S, Vᴴ), alg.trunc)
@@ -391,7 +391,7 @@ function svd_compact!(A::AbstractMatrix, USVᴴ, alg::GPU_SVDAlgorithm)
         throw(ArgumentError("Unsupported SVD algorithm"))
     end
 
-    dogaugefix && gaugefix!(svd_compact!, U, Vᴴ, size(A)...)
+    dogaugefix && gaugefix!(svd_compact!, U, Vᴴ)
 
     return USVᴴ
 end