Change name to TruncationIntersection

Author: mtfishman

src/implementations/truncation.jl

@@ -90,24 +90,25 @@ Truncation strategy to discard the values that are larger than `atol` in absolut
 truncabove(atol) = TruncationKeepFiltered(≤(atol) ∘ abs)
 
 """
-    TruncationComposition(trunc1::TruncationStrategy, trunc2::TruncationStrategy)
+    TruncationIntersection(trunc1::TruncationStrategy, trunc2::TruncationStrategy)
+
 Compose two truncation strategies, keeping values common between the two strategies.
 """
-struct TruncationComposition{T<:Tuple{Vararg{TruncationStrategy}}} <:
+struct TruncationIntersection{T<:Tuple{Vararg{TruncationStrategy}}} <:
        TruncationStrategy
     components::T
 end
 function Base.:&(trunc1::TruncationStrategy, trunc2::TruncationStrategy)
-    return TruncationComposition((trunc1, trunc2))
+    return TruncationIntersection((trunc1, trunc2))
 end
-function Base.:&(trunc1::TruncationComposition, trunc2::TruncationComposition)
-    return TruncationComposition((trunc1.components..., trunc2.components...))
+function Base.:&(trunc1::TruncationIntersection, trunc2::TruncationIntersection)
+    return TruncationIntersection((trunc1.components..., trunc2.components...))
 end
-function Base.:&(trunc1::TruncationComposition, trunc2::TruncationStrategy)
-    return TruncationComposition((trunc1.components..., trunc2))
+function Base.:&(trunc1::TruncationIntersection, trunc2::TruncationStrategy)
+    return TruncationIntersection((trunc1.components..., trunc2))
 end
-function Base.:&(trunc1::TruncationStrategy, trunc2::TruncationComposition)
-    return TruncationComposition((trunc1, trunc2.components...))
+function Base.:&(trunc1::TruncationStrategy, trunc2::TruncationIntersection)
+    return TruncationIntersection((trunc1, trunc2.components...))
 end
 
 # truncate!
@@ -175,7 +176,7 @@ function findtruncated(values::AbstractVector, strategy::TruncationKeepAbove)
     return 1:i
 end
 
-function findtruncated(values::AbstractVector, strategy::TruncationComposition)
+function findtruncated(values::AbstractVector, strategy::TruncationIntersection)
     inds = map(Base.Fix1(findtruncated, values), strategy.components)
     return intersect(inds...)
 end

test/truncate.jl

@@ -1,7 +1,7 @@
 using MatrixAlgebraKit
 using Test
 using TestExtras
-using MatrixAlgebraKit: NoTruncation, TruncationComposition, TruncationKeepAbove,
+using MatrixAlgebraKit: NoTruncation, TruncationIntersection, TruncationKeepAbove,
                         TruncationStrategy
 
 @testset "truncate" begin
@@ -22,7 +22,7 @@ using MatrixAlgebraKit: NoTruncation, TruncationComposition, TruncationKeepAbove
     @test trunc.rev == true
 
     trunc = @constinferred TruncationStrategy(; atol=1e-2, rtol=1e-3, maxrank=10)
-    @test trunc isa TruncationComposition
+    @test trunc isa TruncationIntersection
     @test trunc == truncrank(10) & TruncationKeepAbove(1e-2, 1e-3)
     @test trunc.components[1] == truncrank(10)
     @test trunc.components[2] == TruncationKeepAbove(1e-2, 1e-3)