Skip to content

Commit 49b1536

Browse files
committed
mark randomized SVD as unusable for nullspaces
1 parent eb64f39 commit 49b1536

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

src/implementations/orthnull.jl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,6 @@ end
103103

104104
# Implementation of null functions
105105
# --------------------------------
106-
107-
108106
left_null!(A, N, alg::AbstractAlgorithm) = left_null_kind(alg)(A, N, alg)
109107
left_null_qr!(A, N, alg::AbstractAlgorithm) = qr_null!(A, N, alg)
110108

@@ -123,3 +121,9 @@ function right_null_svd!(A, Nᴴ, alg::TruncatedAlgorithm)
123121
Nᴴ, _ = truncate(right_null!, (S, Vᴴ), alg.trunc)
124122
return Nᴴ
125123
end
124+
125+
# randomized algorithms don't work for smallest values:
126+
left_null_svd!(A, N, alg::TruncatedAlgorithm{<:GPU_Randomized}) =
127+
throw(ArgumentError("Randomized SVD ($alg) cannot be used for null spaces"))
128+
right_null_svd!(A, Nᴴ, alg::TruncatedAlgorithm{<:GPU_Randomized}) =
129+
throw(ArgumentError("Randomized SVD ($alg) cannot be used for null spaces"))

0 commit comments

Comments
 (0)