simplify mooncake tests

Author: lkdvos

ext/MatrixAlgebraKitMooncakeExt/MatrixAlgebraKitMooncakeExt.jl

@@ -795,7 +795,7 @@ for (f!, f, adj) in (
                 dA .+= $f(darg)
                 dA === darg || zero!(darg)
                 copy!(arg, argc)
-                return NoRData(), NoRData(), NoRData(), NoRData()
+                return ntuple(Returns(NoRData()), 4)
             end
             return arg_darg, $adj
         end
@@ -810,10 +810,11 @@ for (f!, f, adj) in (
             function $adj(::NoRData)
                 # TODO: need accumulating projection to avoid intermediate here
                 dA .+= $f(doutput)
-                return ntuple(Returns(NoRData(), 3))
+                zero!(doutput)
+                return ntuple(Returns(NoRData()), 3)
             end
 
-            return output_codual, $adj
+            return output_doutput, $adj
         end
     end
 end

test/testsuite/mooncake.jl

@@ -550,25 +550,17 @@ function test_mooncake_projections(
         m, n = size(A)
         if m == n
             @testset "project_hermitian" begin
-                Aₕ, ΔAₕ = ad_project_hermitian_setup(A)
-                dAₕ = make_mooncake_tangent(ΔAₕ)
-                Mooncake.TestUtils.test_rule(rng, project_hermitian, A; is_primitive = false, mode = Mooncake.ReverseMode, output_tangent = dAₕ, atol, rtol)
+                Aₕ = project_hermitian(A)
+                ΔAₕ = make_mooncake_tangent(Aₕ)
+                Mooncake.TestUtils.test_rule(rng, project_hermitian, A; is_primitive = false, mode = Mooncake.ReverseMode, atol, rtol)
                 test_pullbacks_match(project_hermitian!, project_hermitian, A, Aₕ, ΔAₕ)
             end
             @testset "project_antihermitian" begin
-                Aₐ, ΔAₐ = ad_project_antihermitian_setup(A)
-                dAₐ = make_mooncake_tangent(ΔAₐ)
-                Mooncake.TestUtils.test_rule(rng, project_antihermitian, A; is_primitive = false, mode = Mooncake.ReverseMode, output_tangent = dAₐ, atol, rtol)
+                Aₐ = project_antihermitian(A)
+                ΔAₐ = make_mooncake_tangent(Aₐ)
+                Mooncake.TestUtils.test_rule(rng, project_antihermitian, A; is_primitive = false, mode = Mooncake.ReverseMode, atol, rtol)
                 test_pullbacks_match(project_antihermitian!, project_antihermitian, A, Aₐ, ΔAₐ)
             end
         end
-        if m > n
-            @testset "project_isometric" begin
-                W, ΔW = ad_project_isometric_setup(A)
-                dW = make_mooncake_tangent(ΔW)
-                Mooncake.TestUtils.test_rule(rng, project_isometric, A; is_primitive = false, mode = Mooncake.ReverseMode, output_tangent = dW, atol, rtol)
-                test_pullbacks_match(project_isometric!, project_isometric, A, W, ΔW)
-            end
-        end
     end
 end