We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent a53006e commit 5ffd58eCopy full SHA for 5ffd58e
1 file changed
src/implementations/lq.jl
@@ -164,9 +164,10 @@ function lq_householder!(
164
end
165
166
if computeL
167
- L̃ = lowertriangular!(view(A, axes(L)...))
168
- positive && gaugefix!(lq_householder!, L̃, Q, diagview(A))
169
- copyto!(L, L̃)
+ # we need to first copy then gaugefix - avoiding aliasing between L and Ld for broadcast
+ Ld = diagview(A)
+ copyto!(L, lowertriangular!(view(A, axes(L)...)))
170
+ positive && gaugefix!(lq_householder!, L, Q, Ld)
171
else
172
gaugefix!(lq_householder!, nothing, Q, diagview(A))
173
0 commit comments