comments

Author: kshyatt

test/lq.jl

@@ -40,26 +40,24 @@ for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
             TestSuite.test_lq(T, (m, n))
             LAPACK_LQ_ALGS = (
                 LAPACK_HouseholderLQ(; positive = false, pivoted = false, blocksize = 1),
-                LAPACK_HouseholderLQ(; positive = false, pivoted = false, blocksize = 2),
+                LAPACK_HouseholderLQ(; positive = false, pivoted = false, blocksize = 8),
                 LAPACK_HouseholderLQ(; positive = false, pivoted = true, blocksize = 1),
-                #LAPACK_HouseholderLQ(; positive=false, pivoted=true, blocksize=2), # not supported
+                #LAPACK_HouseholderLQ(; positive=false, pivoted=true, blocksize=8), # not supported
                 LAPACK_HouseholderLQ(; positive = true, pivoted = false, blocksize = 1),
-                LAPACK_HouseholderLQ(; positive = true, pivoted = false, blocksize = 2),
+                LAPACK_HouseholderLQ(; positive = true, pivoted = false, blocksize = 8),
                 LAPACK_HouseholderLQ(; positive = true, pivoted = true, blocksize = 1),
-                #LAPACK_HouseholderLQ(; positive=true, pivoted=true, blocksize=2), # not supported
+                #LAPACK_HouseholderLQ(; positive=true, pivoted=true, blocksize=8), # not supported
             )
             TestSuite.test_lq_algs(T, (m, n), LAPACK_LQ_ALGS)
         elseif T ∈ GenericFloats
             TestSuite.test_lq(T, (m, n); test_null = false, test_pivoted = false, test_blocksize = false)
             GLA_LQ_ALGS = (LQViaTransposedQR(GLA_HouseholderQR()),)
             TestSuite.test_lq_algs(T, (m, n), GLA_LQ_ALGS; test_null = false)
         end
-    end
-end
-if !is_buildkite
-    for T in (BLASFloats..., GenericFloats...)
-        AT = Diagonal{T, Vector{T}}
-        TestSuite.test_lq(AT, m; test_pivoted = false, test_blocksize = false)
-        TestSuite.test_lq_algs(AT, m, (DiagonalAlgorithm(),))
+        if m == n
+            AT = Diagonal{T, Vector{T}}
+            TestSuite.test_lq(AT, m; test_pivoted = false, test_blocksize = false)
+            TestSuite.test_lq_algs(AT, m, (DiagonalAlgorithm(),))
+        end
     end
 end

test/qr.jl

@@ -39,26 +39,24 @@ for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
             TestSuite.test_qr(T, (m, n))
             LAPACK_QR_ALGS = (
                 LAPACK_HouseholderQR(; positive = false, pivoted = false, blocksize = 1),
-                LAPACK_HouseholderQR(; positive = false, pivoted = false, blocksize = 2),
+                LAPACK_HouseholderQR(; positive = false, pivoted = false, blocksize = 8),
                 LAPACK_HouseholderQR(; positive = false, pivoted = true, blocksize = 1),
-                #LAPACK_HouseholderQR(; positive=false, pivoted=true, blocksize=2), # not supported
+                #LAPACK_HouseholderQR(; positive=false, pivoted=true, blocksize=8), # not supported
                 LAPACK_HouseholderQR(; positive = true, pivoted = false, blocksize = 1),
-                LAPACK_HouseholderQR(; positive = true, pivoted = false, blocksize = 2),
+                LAPACK_HouseholderQR(; positive = true, pivoted = false, blocksize = 8),
                 LAPACK_HouseholderQR(; positive = true, pivoted = true, blocksize = 1),
-                #LAPACK_HouseholderQR(; positive=true, pivoted=true, blocksize=2), # not supported
+                #LAPACK_HouseholderQR(; positive=true, pivoted=true, blocksize=8), # not supported
             )
             TestSuite.test_qr_algs(T, (m, n), LAPACK_QR_ALGS)
         elseif T ∈ GenericFloats
             TestSuite.test_qr(T, (m, n); test_null = false, test_pivoted = false, test_blocksize = false)
             GLA_QR_ALGS = (GLA_HouseholderQR(),)
             TestSuite.test_qr_algs(T, (m, n), GLA_QR_ALGS; test_null = false)
         end
-    end
-end
-if !is_buildkite
-    for T in (BLASFloats..., GenericFloats...)
-        AT = Diagonal{T, Vector{T}}
-        TestSuite.test_qr(AT, m; test_pivoted = false, test_blocksize = false)
-        TestSuite.test_qr_algs(AT, m, (DiagonalAlgorithm(),))
+        if m == n
+            AT = Diagonal{T, Vector{T}}
+            TestSuite.test_qr(AT, m; test_pivoted = false, test_blocksize = false)
+            TestSuite.test_qr_algs(AT, m, (DiagonalAlgorithm(),))
+        end
     end
 end