Test truncated methods with GPU arrays

Author: kshyatt

test/eig.jl

@@ -19,10 +19,10 @@ for T in (BLASFloats..., GenericFloats...)
     TestSuite.seed_rng!(123)
     if T ∈ BLASFloats
         if CUDA.functional()
-            TestSuite.test_eig(CuMatrix{T}, (m, m); test_trunc = false)
-            TestSuite.test_eig_algs(CuMatrix{T}, (m, m), (CUSOLVER_Simple(),); test_trunc = false)
-            TestSuite.test_eig(Diagonal{T, CuVector{T}}, m; test_trunc = false)
-            TestSuite.test_eig_algs(Diagonal{T, CuVector{T}}, m, (DiagonalAlgorithm(),); test_trunc = false)
+            TestSuite.test_eig(CuMatrix{T}, (m, m))
+            TestSuite.test_eig_algs(CuMatrix{T}, (m, m), (CUSOLVER_Simple(),))
+            TestSuite.test_eig(Diagonal{T, CuVector{T}}, m)
+            TestSuite.test_eig_algs(Diagonal{T, CuVector{T}}, m, (DiagonalAlgorithm(),))
         end
         #= not yet supported
         if AMDGPU.functional()

test/eigh.jl

@@ -22,10 +22,10 @@ for T in (BLASFloats..., GenericFloats...)
                 CUSOLVER_Jacobi(),
                 CUSOLVER_DivideAndConquer(),
             )
-            TestSuite.test_eigh(CuMatrix{T}, (m, m); test_trunc = false)
-            TestSuite.test_eigh_algs(CuMatrix{T}, (m, m), CUSOLVER_EIGH_ALGS; test_trunc = false)
-            TestSuite.test_eigh(Diagonal{T, CuVector{T}}, m; test_trunc = false)
-            TestSuite.test_eigh_algs(Diagonal{T, CuVector{T}}, m, (DiagonalAlgorithm(),); test_trunc = false)
+            TestSuite.test_eigh(CuMatrix{T}, (m, m))
+            TestSuite.test_eigh_algs(CuMatrix{T}, (m, m), CUSOLVER_EIGH_ALGS)
+            TestSuite.test_eigh(Diagonal{T, CuVector{T}}, m)
+            TestSuite.test_eigh_algs(Diagonal{T, CuVector{T}}, m, (DiagonalAlgorithm(),))
         end
         if AMDGPU.functional()
             ROCSOLVER_EIGH_ALGS = (
@@ -34,10 +34,10 @@ for T in (BLASFloats..., GenericFloats...)
                 ROCSOLVER_QRIteration(),
                 ROCSOLVER_Bisection(),
             )
-            TestSuite.test_eigh(ROCMatrix{T}, (m, m); test_trunc = false)
-            TestSuite.test_eigh_algs(ROCMatrix{T}, (m, m), ROCSOLVER_EIGH_ALGS; test_trunc = false)
-            TestSuite.test_eigh(Diagonal{T, ROCVector{T}}, m; test_trunc = false)
-            TestSuite.test_eigh_algs(Diagonal{T, ROCVector{T}}, m, (DiagonalAlgorithm(),); test_trunc = false)
+            TestSuite.test_eigh(ROCMatrix{T}, (m, m))
+            TestSuite.test_eigh_algs(ROCMatrix{T}, (m, m), ROCSOLVER_EIGH_ALGS)
+            TestSuite.test_eigh(Diagonal{T, ROCVector{T}}, m)
+            TestSuite.test_eigh_algs(Diagonal{T, ROCVector{T}}, m, (DiagonalAlgorithm(),))
         end
     end
     if !is_buildkite

test/testsuite/eig.jl

@@ -3,19 +3,19 @@ using MatrixAlgebraKit: TruncatedAlgorithm
 using LinearAlgebra: I
 using GenericSchur
 
-function test_eig(T::Type, sz; test_trunc = true, kwargs...)
+function test_eig(T::Type, sz; kwargs...)
     summary_str = testargs_summary(T, sz)
     return @testset "eig $summary_str" begin
         test_eig_full(T, sz; kwargs...)
-        test_trunc && test_eig_trunc(T, sz; kwargs...)
+        test_eig_trunc(T, sz; kwargs...)
     end
 end
 
-function test_eig_algs(T::Type, sz, algs; test_trunc = true, kwargs...)
+function test_eig_algs(T::Type, sz, algs; kwargs...)
     summary_str = testargs_summary(T, sz)
     return @testset "eig algorithms $summary_str" begin
         test_eig_full_algs(T, sz, algs; kwargs...)
-        test_trunc && test_eig_trunc_algs(T, sz, algs; kwargs...)
+        test_eig_trunc_algs(T, sz, algs; kwargs...)
     end
 end
 

test/testsuite/eigh.jl

@@ -3,19 +3,19 @@ using GenericLinearAlgebra
 using MatrixAlgebraKit: TruncatedAlgorithm
 using LinearAlgebra: I, opnorm
 
-function test_eigh(T::Type, sz; test_trunc = true, kwargs...)
+function test_eigh(T::Type, sz; kwargs...)
     summary_str = testargs_summary(T, sz)
     return @testset "eigh $summary_str" begin
         test_eigh_full(T, sz; kwargs...)
-        test_trunc && test_eigh_trunc(T, sz; kwargs...)
+        test_eigh_trunc(T, sz; kwargs...)
     end
 end
 
-function test_eigh_algs(T::Type, sz, algs; test_trunc = true, kwargs...)
+function test_eigh_algs(T::Type, sz, algs; kwargs...)
     summary_str = testargs_summary(T, sz)
     return @testset "eigh algorithms $summary_str" begin
         test_eigh_full_algs(T, sz, algs; kwargs...)
-        test_trunc && test_eigh_trunc_algs(T, sz, algs; kwargs...)
+        test_eigh_trunc_algs(T, sz, algs; kwargs...)
     end
 end