Skip to content

Commit 76ff5c9

Browse files
committed
Resolve comments
1 parent 8877460 commit 76ff5c9

9 files changed

Lines changed: 6 additions & 12 deletions

File tree

ext/MatrixAlgebraKitAMDGPUExt/yarocsolver.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,6 @@ for (fname, elty, relty) in
164164

165165
AMDGPU.unsafe_free!(dev_residual)
166166
AMDGPU.unsafe_free!(dev_n_sweeps)
167-
#if jobvt == rocSOLVER.rocblas_svect_singular || jobvt == rocSOLVER.rocblas_svect_all
168-
# adjoint!(Vᴴ, Ṽ)
169-
#end
170167
return U, S, Vᴴ
171168
end
172169
end

test/amd/lq.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ using TestExtras
55
using StableRNGs
66
using AMDGPU
77

8-
include("utilities.jl")
8+
include(joinpath("..", "utilities.jl"))
99

1010
@testset "lq_compact! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64)
1111
rng = StableRNG(123)

test/amd/qr.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ using TestExtras
55
using StableRNGs
66
using AMDGPU
77

8-
include("utilities.jl")
8+
include(joinpath("..", "utilities.jl"))
99

1010
@testset "qr_compact! and qr_null! for T = $T" for T in (Float32, Float64, ComplexF32,
1111
ComplexF64)

test/amd/svd.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ using TestExtras
66
using StableRNGs
77
using AMDGPU
88

9-
include("utilities.jl")
9+
include(joinpath("..", "utilities.jl"))
1010

1111
@testset "svd_compact! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64)
1212
rng = StableRNG(123)

test/cuda/lq.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ using TestExtras
55
using StableRNGs
66
using CUDA
77

8-
include("utilities.jl")
8+
include(joinpath("..", "utilities.jl"))
99

1010
@testset "lq_compact! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64)
1111
rng = StableRNG(123)

test/cuda/qr.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ using TestExtras
55
using StableRNGs
66
using CUDA
77

8-
include("utilities.jl")
8+
include(joinpath("..", "utilities.jl"))
99

1010
@testset "qr_compact! and qr_null! for T = $T" for T in (Float32, Float64, ComplexF32,
1111
ComplexF64)

test/cuda/svd.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ using TestExtras
66
using StableRNGs
77
using CUDA
88

9-
include("utilities.jl")
9+
include(joinpath("..", "utilities.jl"))
1010

1111
@testset "svd_compact! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64)
1212
rng = StableRNG(123)

test/cuda/utilities.jl

Lines changed: 0 additions & 3 deletions
This file was deleted.
File renamed without changes.

0 commit comments

Comments
 (0)