More comments

Author: Katharine Hyatt

test/runtests.jl

@@ -25,11 +25,12 @@ if filter_tests!(testsuite, args)
         delete!(testsuite, "codequality")
     else
         is_apple_ci = Sys.isapple() && get(ENV, "CI", "false") == "true"
+        is_windows_ci = Sys.isapple() && get(ENV, "CI", "false") == "true"
         if is_apple_ci
             filter!(p -> !startswith(first(p), "mooncake/"), testsuite)
             delete!(testsuite, "chainrules")
         end
-        (Sys.iswindows() || is_apple_ci) && filter!(p -> !startswith(first(p), "enzyme/"), testsuite)
+        (is_windows_ci || is_apple_ci) && filter!(p -> !startswith(first(p), "enzyme/"), testsuite)
     end
 end
 

test/testsuite/ad_utils.jl

@@ -1,21 +1,3 @@
-"""
-    remove_svd_gauge_dependence!(ΔV, D, V)
-
-Remove the gauge-dependent part from the cotangents `ΔU` and ΔVᴴ` of the singular vector matrices `U`
-and `Vᴴ`. The singular vectors are only determined up to complex phase (and unitary mixing for degenerate
-eigenvalues), so the corresponding components of `ΔU` and `ΔVᴴ` are projected out.
-"""
-function remove_svd_gauge_dependence!(
-        ΔU, ΔVᴴ, U, S, Vᴴ;
-        degeneracy_atol = MatrixAlgebraKit.default_pullback_gauge_atol(S)
-    )
-    gaugepart = mul!(U' * ΔU, Vᴴ, ΔVᴴ', true, true)
-    gaugepart = project_antihermitian!(gaugepart)
-    gaugepart[abs.(transpose(diagview(S)) .- diagview(S)) .>= degeneracy_atol] .= 0
-    mul!(ΔU, U, gaugepart, -1, 1)
-    return ΔU, ΔVᴴ
-end
-
 """
     remove_eig_gauge_dependence!(ΔV, D, V)
 
@@ -254,11 +236,6 @@ function ad_qr_compact_setup(A::Diagonal)
 end
 
 function ad_qr_null_setup(A)
-    m, n = size(A)
-    minmn = min(m, n)
-    Q, R = qr_compact(A)
-    T = eltype(A)
-    ΔN = Q * randn!(similar(A, T, minmn, max(0, m - minmn)))
     N = qr_null(A)
     ΔN = randn!(copy(N))
     remove_qr_null_gauge_dependence!(ΔN, A, N)

test/testsuite/enzyme/enzyme.jl

@@ -50,8 +50,8 @@ function test_mooncake_eigh_vals(
     return @testset "eigh_vals" begin
         A = make_eigh_matrix(T, sz)
         alg = MatrixAlgebraKit.select_algorithm(eigh_vals, A)
-        D, ΔD = ad_eigh_vals_setup(A)
-        output_tangent = Mooncake.primal_to_tangent!!(Mooncake.zero_tangent(D), ΔD)
+        D = eigh_vals(A, alg)
+        output_tangent = Mooncake.randn_tangent(rng, D)
 
         Mooncake.TestUtils.test_rule(
             rng, eigh_wrapper, eigh_vals, A, alg;