We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent d0c762a commit 809eea3Copy full SHA for 809eea3
1 file changed
ext/MatrixAlgebraKitChainRulesCoreExt.jl
@@ -43,8 +43,7 @@ for qr_f in (:qr_compact, :qr_full)
43
end
44
function ChainRulesCore.rrule(::typeof(qr_null!), A::AbstractMatrix, N, alg)
45
Ac = copy_input(qr_full, A)
46
- QR = initialize_output(qr_full!, A, alg)
47
- QR = qr_full!(Ac, QR, alg)
+ QR = qr_full!(Ac, initialize_output(qr_full!, A, alg), alg)
48
N = copy!(N, view(QR[1], 1:size(A, 1), (size(A, 2) + 1):size(A, 1)))
49
function qr_null_pullback(ΔN)
50
ΔA = zero(A)
@@ -77,8 +76,7 @@ for lq_f in (:lq_compact, :lq_full)
77
76
78
function ChainRulesCore.rrule(::typeof(lq_null!), A::AbstractMatrix, Nᴴ, alg)
79
Ac = copy_input(lq_full, A)
80
- LQ = initialize_output(lq_full!, A, alg)
81
- LQ = lq_full!(Ac, LQ, alg)
+ LQ = lq_full!(Ac, initialize_output(lq_full!, A, alg), alg)
82
Nᴴ = copy!(Nᴴ, view(LQ[2], (size(A, 1) + 1):size(A, 2), 1:size(A, 2)))
83
function lq_null_pullback(ΔNᴴ)
84
0 commit comments