Skip to content

Commit 809eea3

Browse files
committed
fix type stability
1 parent d0c762a commit 809eea3

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

ext/MatrixAlgebraKitChainRulesCoreExt.jl

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ for qr_f in (:qr_compact, :qr_full)
4343
end
4444
function ChainRulesCore.rrule(::typeof(qr_null!), A::AbstractMatrix, N, alg)
4545
Ac = copy_input(qr_full, A)
46-
QR = initialize_output(qr_full!, A, alg)
47-
QR = qr_full!(Ac, QR, alg)
46+
QR = qr_full!(Ac, initialize_output(qr_full!, A, alg), alg)
4847
N = copy!(N, view(QR[1], 1:size(A, 1), (size(A, 2) + 1):size(A, 1)))
4948
function qr_null_pullback(ΔN)
5049
ΔA = zero(A)
@@ -77,8 +76,7 @@ for lq_f in (:lq_compact, :lq_full)
7776
end
7877
function ChainRulesCore.rrule(::typeof(lq_null!), A::AbstractMatrix, Nᴴ, alg)
7978
Ac = copy_input(lq_full, A)
80-
LQ = initialize_output(lq_full!, A, alg)
81-
LQ = lq_full!(Ac, LQ, alg)
79+
LQ = lq_full!(Ac, initialize_output(lq_full!, A, alg), alg)
8280
Nᴴ = copy!(Nᴴ, view(LQ[2], (size(A, 1) + 1):size(A, 2), 1:size(A, 2)))
8381
function lq_null_pullback(ΔNᴴ)
8482
ΔA = zero(A)

0 commit comments

Comments
 (0)