Don't overtest Diagonals

Author: kshyatt

test/lq.jl

@@ -19,11 +19,11 @@ for T in BLASFloats, n in (37, m, 63)
     if is_buildkite
         if CUDA.functional()
             TestSuite.test_lq(CuMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
-            TestSuite.test_lq(Diagonal{T, CuVector{T}}, m; test_pivoted = false, test_blocksize = false)
+            n == m && TestSuite.test_lq(Diagonal{T, CuVector{T}}, m; test_pivoted = false, test_blocksize = false)
         end
         if AMDGPU.functional()
             TestSuite.test_lq(ROCMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
-            TestSuite.test_lq(Diagonal{T, ROCVector{T}}, m; test_pivoted = false, test_blocksize = false)
+            n == m && TestSuite.test_lq(Diagonal{T, ROCVector{T}}, m; test_pivoted = false, test_blocksize = false)
         end
     else
         TestSuite.test_lq(T, (m, n); test_pivoted = false)

test/orthnull.jl

@@ -18,12 +18,12 @@ for T in BLASFloats, n in (37, m, 63)
     TestSuite.seed_rng!(123)
     if is_buildkite
         if CUDA.functional()
-            TestSuite.test_orthnull(CuMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
-            TestSuite.test_orthnull(Diagonal{T, CuVector{T}}, m; test_pivoted = false, test_blocksize = false)
+            TestSuite.test_orthnull(CuMatrix{T}, (m, n); test_blocksize = false)
+            n == m && TestSuite.test_orthnull(Diagonal{T, CuVector{T}}, m; test_blocksize = false)
         end
         if AMDGPU.functional()
-            TestSuite.test_orthnull(ROCMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
-            TestSuite.test_orthnull(Diagonal{T, ROCVector{T}}, m; test_pivoted = false, test_blocksize = false)
+            TestSuite.test_orthnull(ROCMatrix{T}, (m, n); test_blocksize = false)
+            n == m && TestSuite.test_orthnull(Diagonal{T, ROCVector{T}}, m; test_blocksize = false)
         end
     else
         TestSuite.test_orthnull(T, (m, n))
@@ -32,6 +32,6 @@ end
 if !is_buildkite
     for T in (BLASFloats..., GenericFloats...)
         AT = Diagonal{T, Vector{T}}
-        TestSuite.test_orthnull(AT, m; test_pivoted = false, test_blocksize = false)
+        TestSuite.test_orthnull(AT, m; test_blocksize = false)
     end
 end

test/polar.jl

@@ -19,12 +19,12 @@ for T in BLASFloats, n in (37, m, 63)
         if CUDA.functional()
             TestSuite.test_polar(CuMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
             # not supported
-            #TestSuite.test_polar(Diagonal{T, CuVector{T}}, m; test_pivoted = false, test_blocksize = false)
+            #n == m && TestSuite.test_polar(Diagonal{T, CuVector{T}}, m; test_pivoted = false, test_blocksize = false)
         end
         if AMDGPU.functional()
             TestSuite.test_polar(ROCMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
             # not supported
-            #TestSuite.test_polar(Diagonal{T, ROCVector{T}}, m; test_pivoted = false, test_blocksize = false)
+            #n == m && TestSuite.test_polar(Diagonal{T, ROCVector{T}}, m; test_pivoted = false, test_blocksize = false)
         end
     else
         TestSuite.test_polar(T, (m, n))

test/qr.jl

@@ -18,11 +18,11 @@ for T in BLASFloats, n in (37, m, 63)
     if is_buildkite
         if CUDA.functional()
             TestSuite.test_qr(CuMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
-            TestSuite.test_qr(Diagonal{T, CuVector{T}}, m; test_pivoted = false, test_blocksize = false)
+            n == m && TestSuite.test_qr(Diagonal{T, CuVector{T}}, m; test_pivoted = false, test_blocksize = false)
         end
         if AMDGPU.functional()
             TestSuite.test_qr(ROCMatrix{T}, (m, n); test_pivoted = false, test_blocksize = false)
-            TestSuite.test_qr(Diagonal{T, ROCVector{T}}, m; test_pivoted = false, test_blocksize = false)
+            n == m && TestSuite.test_qr(Diagonal{T, ROCVector{T}}, m; test_pivoted = false, test_blocksize = false)
         end
     else
         TestSuite.test_qr(T, (m, n))

test/svd.jl

@@ -19,11 +19,11 @@ for T in BLASFloats, n in (37, m, 63, 0)
     if is_buildkite
         if CUDA.functional()
             TestSuite.test_svd(CuMatrix{T}, (m, n); test_blocksize = false)
-            TestSuite.test_svd(Diagonal{T, CuVector{T}}, m; test_blocksize = false)
+            n == m && TestSuite.test_svd(Diagonal{T, CuVector{T}}, m; test_blocksize = false)
         end
         if AMDGPU.functional()
             TestSuite.test_svd(ROCMatrix{T}, (m, n); test_blocksize = false)
-            TestSuite.test_svd(Diagonal{T, ROCVector{T}}, m; test_blocksize = false)
+            n == m && TestSuite.test_svd(Diagonal{T, ROCVector{T}}, m; test_blocksize = false)
         end
     else
         TestSuite.test_svd(T, (m, n))