Test svd_trunc for GPU

Author: kshyatt

test/svd.jl

@@ -17,28 +17,28 @@ for T in (BLASFloats..., GenericFloats...), m in (0, 54), n in (0, 37, m, 63)
     TestSuite.seed_rng!(123)
     if T ∈ BLASFloats
         if CUDA.functional()
-            TestSuite.test_svd(CuMatrix{T}, (m, n); test_trunc = false)
+            TestSuite.test_svd(CuMatrix{T}, (m, n))
             CUDA_SVD_ALGS = (
                 CUSOLVER_QRIteration(),
                 CUSOLVER_SVDPolar(),
                 CUSOLVER_Jacobi(),
             )
-            TestSuite.test_svd_algs(CuMatrix{T}, (m, n), CUDA_SVD_ALGS; test_trunc = false)
+            TestSuite.test_svd_algs(CuMatrix{T}, (m, n), CUDA_SVD_ALGS)
             if n == m
-                TestSuite.test_svd(Diagonal{T, CuVector{T}}, m; test_trunc = false)
-                TestSuite.test_svd_algs(Diagonal{T, CuVector{T}}, m, (DiagonalAlgorithm(),); test_trunc = false)
+                TestSuite.test_svd(Diagonal{T, CuVector{T}}, m)
+                TestSuite.test_svd_algs(Diagonal{T, CuVector{T}}, m, (DiagonalAlgorithm(),))
             end
         end
         if AMDGPU.functional()
-            TestSuite.test_svd(ROCMatrix{T}, (m, n); test_trunc = false)
+            TestSuite.test_svd(ROCMatrix{T}, (m, n))
             AMD_SVD_ALGS = (
                 ROCSOLVER_QRIteration(),
                 ROCSOLVER_Jacobi(),
             )
-            TestSuite.test_svd_algs(ROCMatrix{T}, (m, n), AMD_SVD_ALGS; test_trunc = false)
+            TestSuite.test_svd_algs(ROCMatrix{T}, (m, n), AMD_SVD_ALGS)
             if n == m
-                TestSuite.test_svd(Diagonal{T, ROCVector{T}}, m; test_trunc = false)
-                TestSuite.test_svd_algs(Diagonal{T, ROCVector{T}}, m, (DiagonalAlgorithm(),); test_trunc = false)
+                TestSuite.test_svd(Diagonal{T, ROCVector{T}}, m)
+                TestSuite.test_svd_algs(Diagonal{T, ROCVector{T}}, m, (DiagonalAlgorithm(),))
             end
         end
     end

test/testsuite/svd.jl

@@ -2,21 +2,21 @@ using TestExtras
 using GenericLinearAlgebra
 using LinearAlgebra: opnorm
 
-function test_svd(T::Type, sz; test_trunc = true, kwargs...)
+function test_svd(T::Type, sz; kwargs...)
     summary_str = testargs_summary(T, sz)
     return @testset "svd $summary_str" begin
         test_svd_compact(T, sz; kwargs...)
         test_svd_full(T, sz; kwargs...)
-        test_trunc && test_svd_trunc(T, sz; kwargs...)
+        test_svd_trunc(T, sz; kwargs...)
     end
 end
 
-function test_svd_algs(T::Type, sz, algs; test_trunc = true, kwargs...)
+function test_svd_algs(T::Type, sz, algs; kwargs...)
     summary_str = testargs_summary(T, sz)
     return @testset "svd algorithms $summary_str" begin
         test_svd_compact_algs(T, sz, algs; kwargs...)
         test_svd_full_algs(T, sz, algs; kwargs...)
-        test_trunc && test_svd_trunc_algs(T, sz, algs; kwargs...)
+        test_svd_trunc_algs(T, sz, algs; kwargs...)
     end
 end