Fixes

Author: Katharine Hyatt

test/linearmap.jl

@@ -38,7 +38,7 @@ module LinearMaps
     # Using AbstractAlgorithm here would be ambiguous since neither A-type nor alg-type would
     # be strictly more specific.
     for f! in (:svd_compact!, :svd_full!)
-        for Alg in (:SafeDivideAndConquer, :DivideAndConquer, :QRIteration, :Bisection, :Jacobi, :SVDViaPolar)
+        for Alg in (:SafeDivideAndConquer, :DivideAndConquer, :QRIteration, :Bisection, :Jacobi, :SVDViaPolar, :DiagonalAlgorithm)
             @eval MAK.$f!(A::LinearMap, USVᴴ, alg::MAK.$Alg) =
                 LinearMap.(MAK.$f!(parent(A), parent.(USVᴴ), alg))
         end

test/testsuite/TestSuite.jl

@@ -76,11 +76,11 @@ is_pivoted(alg::MatrixAlgebraKit.LQViaTransposedQR) = is_pivoted(alg.qr_alg)
 isleftcomplete(V, N) = V * V' + N * N' ≈ I
 isleftcomplete(V::AnyCuMatrix, N::AnyCuMatrix) = isleftcomplete(collect(V), collect(N))
 isleftcomplete(V::AnyROCMatrix, N::AnyROCMatrix) = isleftcomplete(collect(V), collect(N))
-isleftcomplete(V::Diagonal{TV, <:AnyROCVector}, N::Diagonal{TN, <:AnyROCVector}) where {TV, TN} = isleftcomplete(Diagonal(collect(V.diag)), Diagonal(collect(N.diag)))
+isleftcomplete(V::Diagonal{TV, <:AnyROCVector}, N::AnyROCMatrix) where {TV} = isleftcomplete(Diagonal(collect(V.diag)), collect(N))
 isrightcomplete(Vᴴ, Nᴴ) = Vᴴ' * Vᴴ + Nᴴ' * Nᴴ ≈ I
 isrightcomplete(V::AnyCuMatrix, N::AnyCuMatrix) = isrightcomplete(collect(V), collect(N))
 isrightcomplete(V::AnyROCMatrix, N::AnyROCMatrix) = isrightcomplete(collect(V), collect(N))
-isrightcomplete(V::Diagonal{TV, <:AnyROCVector}, N::Diagonal{TN, <:AnyROCVector}) where {TV, TN} = isrightcomplete(Diagonal(collect(V.diag)), Diagonal(collect(N.diag)))
+isrightcomplete(V::Diagonal{TV, <:AnyROCVector}, N::AnyROCMatrix) where {TV} = isrightcomplete(Diagonal(collect(V.diag)), collect(N))
 
 instantiate_unitary(T, A, sz) = qr_compact(randn!(similar(A, eltype(T), sz, sz)))[1]
 # AMDGPU can't generate ComplexF32 random numbers