Polar and orthnull

Author: kshyatt

test/enzyme/orthnull.jl

@@ -15,5 +15,7 @@ for T in (BLASFloats..., GenericFloats...), n in (17, m, 23)
     TestSuite.seed_rng!(1234)
     if !is_buildkite
         TestSuite.test_enzyme_orthnull(T, (m, n); atol = m * n * TestSuite.precision(T), rtol = m * n * TestSuite.precision(T))
+        AT = Diagonal{T, Vector{T}}
+        m == n && TestSuite.test_enzyme_orthnull(AT, (m, m); atol = m * m * TestSuite.precision(T), rtol = m * m * TestSuite.precision(T))
     end
 end

test/enzyme/polar.jl

@@ -15,5 +15,7 @@ for T in (BLASFloats..., GenericFloats...), n in (17, m, 23)
     TestSuite.seed_rng!(1234)
     if !is_buildkite
         TestSuite.test_enzyme_polar(T, (m, n); atol = m * n * TestSuite.precision(T), rtol = m * n * TestSuite.precision(T))
+        AT = Diagonal{T, Vector{T}}
+        #m == n && TestSuite.test_enzyme_polar(AT, (m, m); atol = m * m * TestSuite.precision(T), rtol = m * m * TestSuite.precision(T))
     end
 end

test/testsuite/enzyme/orthnull.jl

@@ -37,7 +37,7 @@ function test_enzyme_left_orth(
             test_reverse(call_and_zero!, RT, (left_orth!, Const), (A, TA), (alg, Const); atol, rtol, fdm, output_tangent = ΔVC)
         end
 
-        if m >= n
+        if m >= n && !(T <: Diagonal)
             @testset "polar" begin
                 A = instantiate_matrix(T, sz)
                 alg = MatrixAlgebraKit.select_algorithm(left_orth!, A, :polar)
@@ -71,7 +71,7 @@ function test_enzyme_right_orth(
             test_reverse(call_and_zero!, RT, (right_orth!, Const), (A, TA), (alg, Const); atol, rtol, fdm, output_tangent = ΔCVᴴ)
         end
 
-        if m <= n
+        if m <= n && !(T <: Diagonal)
             @testset "polar" begin
                 A = instantiate_matrix(T, sz)
                 alg = MatrixAlgebraKit.select_algorithm(right_orth!, A, :polar)