Reinstate default_f_algorithm functions

Author: lkdvos

src/interface/eig.jl

@@ -87,14 +87,16 @@ See also [`eig_full(!)`](@ref eig_full) and [`eig_trunc(!)`](@ref eig_trunc).
 
 # Algorithm selection
 # -------------------
-# Default to LAPACK for `YALAPACK.BlasMat`
-function default_algorithm(::typeof(eig_full!), ::Type{A};
-                           kwargs...) where {A<:YALAPACK.BlasMat}
+default_eig_algorithm(A; kwargs...) = default_eig_algorithm(typeof(A); kwargs...)
+default_eig_algorithm(T::Type; kwargs...) = throw(MethodError(default_eig_algorithm, (T,)))
+function default_eig_algorithm(::Type{T}; kwargs...) where {T<:YALAPACK.BlasMat}
     return LAPACK_Expert(; kwargs...)
 end
-function default_algorithm(::typeof(eig_vals!), ::Type{A};
-                           kwargs...) where {A<:YALAPACK.BlasMat}
-    return LAPACK_Expert(; kwargs...)
+
+for f in (:eig_full!, :eig_vals!)
+    @eval function default_algorithm(::typeof($f), ::Type{A}; kwargs...) where {A}
+        return default_eig_algorithm(A; kwargs...)
+    end
 end
 
 function select_algorithm(::typeof(eig_trunc!), ::Type{A}, alg; trunc=nothing,

src/interface/eigh.jl

@@ -86,16 +86,20 @@ See also [`eigh_full(!)`](@ref eigh_full) and [`eigh_trunc(!)`](@ref eigh_trunc)
 
 # Algorithm selection
 # -------------------
-# Default to LAPACK for `YALAPACK.BlasMat`
-function default_algorithm(::typeof(eigh_full!), ::Type{A};
-                           kwargs...) where {A<:YALAPACK.BlasMat}
-    return LAPACK_MultipleRelativelyRobustRepresentations(; kwargs...)
+default_eigh_algorithm(A; kwargs...) = default_eigh_algorithm(typeof(A); kwargs...)
+function default_eigh_algorithm(T::Type; kwargs...)
+    throw(MethodError(default_eigh_algorithm, (T,)))
 end
-function default_algorithm(::typeof(eigh_vals!), ::Type{A};
-                           kwargs...) where {A<:YALAPACK.BlasMat}
+function default_eigh_algorithm(::Type{T}; kwargs...) where {T<:YALAPACK.BlasMat}
     return LAPACK_MultipleRelativelyRobustRepresentations(; kwargs...)
 end
 
+for f in (:eigh_full!, :eigh_vals!)
+    @eval function default_algorithm(::typeof($f), ::Type{A}; kwargs...) where {A}
+        return default_eigh_algorithm(A; kwargs...)
+    end
+end
+
 function select_algorithm(::typeof(eigh_trunc!), ::Type{A}, alg; trunc=nothing,
                           kwargs...) where {A<:YALAPACK.BlasMat}
     alg_eigh = select_algorithm(eigh_full!, A, alg; kwargs...)

src/interface/lq.jl

@@ -68,11 +68,18 @@ See also [`qr_full(!)`](@ref lq_full) and [`qr_compact(!)`](@ref lq_compact).
 
 # Algorithm selection
 # -------------------
+default_lq_algorithm(A; kwargs...) = default_lq_algorithm(typeof(A); kwargs...)
+function default_lq_algorithm(T::Type; kwargs...)
+    throw(MethodError(default_lq_algorithm, (T,)))
+end
+function default_lq_algorithm(::Type{T}; kwargs...) where {T<:YALAPACK.BlasMat}
+    return LAPACK_HouseholderLQ(; kwargs...)
+end
+
 for f in (:lq_full!, :lq_compact!, :lq_null!)
     @eval begin
-        function default_algorithm(::typeof($f), ::Type{A};
-                                   kwargs...) where {A<:YALAPACK.BlasMat}
-            return LAPACK_HouseholderLQ(; kwargs...)
+        function default_algorithm(::typeof($f), ::Type{A}; kwargs...) where {A}
+            return default_lq_algorithm(A; kwargs...)
         end
     end
 end

src/interface/polar.jl

@@ -60,11 +60,16 @@ end
 
 # Algorithm selection
 # -------------------
-function default_algorithm(::typeof(left_polar!), ::Type{A};
-                           kwargs...) where {A<:YALAPACK.BlasMat}
-    return PolarViaSVD(default_algorithm(svd_compact!, A; kwargs...))
-        end
-function default_algorithm(::typeof(right_polar!), ::Type{A};
-                           kwargs...) where {A<:YALAPACK.BlasMat}
-    return PolarViaSVD(default_algorithm(svd_compact!, A; kwargs...))
+default_polar_algorithm(A; kwargs...) = default_polar_algorithm(typeof(A); kwargs...)
+function default_polar_algorithm(T::Type; kwargs...)
+    throw(MethodError(default_polar_algorithm, (T,)))
+end
+function default_polar_algorithm(::Type{T}; kwargs...) where {T<:YALAPACK.BlasMat}
+    return PolarViaSVD(default_algorithm(svd_compact!, T; kwargs...))
+end
+
+for f in (:left_polar!, :right_polar!)
+    @eval function default_algorithm(::typeof($f), ::Type{A}; kwargs...) where {A}
+        return default_polar_algorithm(A; kwargs...)
+    end
 end

src/interface/qr.jl

@@ -68,11 +68,19 @@ See also [`lq_full(!)`](@ref lq_full) and [`lq_compact(!)`](@ref lq_compact).
 
 # Algorithm selection
 # -------------------
+default_qr_algorithm(A; kwargs...) = default_qr_algorithm(typeof(A); kwargs...)
+function default_qr_algorithm(T::Type; kwargs...)
+    throw(MethodError(default_qr_algorithm, (T,)))
+end
+function default_qr_algorithm(::Type{T}; kwargs...) where {T<:YALAPACK.BlasMat}
+    return LAPACK_HouseholderQR(; kwargs...)
+end
+
 for f in (:qr_full!, :qr_compact!, :qr_null!)
     @eval begin
         function default_algorithm(::typeof($f), ::Type{A};
                                    kwargs...) where {A<:YALAPACK.BlasMat}
-            return LAPACK_HouseholderQR(; kwargs...)
+            return default_qr_algorithm(A; kwargs...)
         end
     end
 end

src/interface/schur.jl

@@ -51,11 +51,8 @@ See also [`eig_full(!)`](@ref eig_full) and [`eig_trunc(!)`](@ref eig_trunc).
 
 # Algorithm selection
 # -------------------
-function default_algorithm(::typeof(schur_full!), ::Type{A};
-                           kwargs...) where {A<:YALAPACK.BlasMat}
-    return default_algorithm(eig_full!, A; kwargs...)
-end
-function default_algorithm(::typeof(schur_vals!), ::Type{A};
-                           kwargs...) where {A<:YALAPACK.BlasMat}
-    return default_algorithm(eig_vals!, A; kwargs...)
+for f in (:schur_full!, :schur_vals!)
+    @eval function default_algorithm(::typeof($f), ::Type{A}; kwargs...) where {A}
+        return default_eig_algorithm(A; kwargs...)
+    end
 end

src/interface/svd.jl

@@ -90,11 +90,17 @@ See also [`svd_full(!)`](@ref svd_full), [`svd_compact(!)`](@ref svd_compact) an
 
 # Algorithm selection
 # -------------------
+default_svd_algorithm(A; kwargs...) = default_svd_algorithm(typeof(A); kwargs...)
+function default_svd_algorithm(T::Type; kwargs...)
+    throw(MethodError(default_svd_algorithm, (T,)))
+end
+function default_svd_algorithm(::Type{T}; kwargs...) where {T<:YALAPACK.BlasMat}
+    return LAPACK_DivideAndConquer(; kwargs...)
+end
+
 for f in (:svd_full!, :svd_compact!, :svd_vals!)
-    # Default to LAPACK SDD for `YALAPACK.BlasMat`
-    @eval function default_algorithm(::typeof($f), ::Type{A};
-                                     kwargs...) where {A<:YALAPACK.BlasMat}
-        return LAPACK_DivideAndConquer(; kwargs...)
+    @eval function default_algorithm(::typeof($f), ::Type{A}; kwargs...) where {A}
+        return default_svd_algorithm(A; kwargs...)
     end
 end