Test algorithms for Schur too

Author: kshyatt

src/yalapack.jl

@@ -1423,7 +1423,7 @@ for (gees, geesx, geev, geevx, ggev, elty, celty, relty) in
         (:zgees_, :zgeesx_, :zgeev_, :zgeevx_, :zggev_, :ComplexF64, :ComplexF64, :Float64),
     )
     @eval begin
-        #=function gees!(
+        function gees!(
                 A::AbstractMatrix{$elty},
                 V::AbstractMatrix{$elty} = similar(A),
                 vals::AbstractVector{$celty} = similar(A, $celty, size(A, 1))
@@ -1501,7 +1501,7 @@ for (gees, geesx, geev, geevx, ggev, elty, celty, relty) in
                 _reorder_realeigendecomposition!(vals, valsR, valsI, work, V, 'N')
             end
             return A, V, vals
-        end=#
+        end
         function geesx!(
                 A::AbstractMatrix{$elty},
                 V::AbstractMatrix{$elty} = similar(A),

test/schur.jl

@@ -27,6 +27,10 @@ for T in (BLASFloats..., GenericFloats...)
     end
     if !is_buildkite
         TestSuite.test_schur(T, (m, m))
+        if T ∈ BLASFloats
+            LAPACK_SCHUR_ALGS = (LAPACK_Simple(), LAPACK_Expert())
+            TestSuite.test_schur_algs(T, (m, m), LAPACK_SCHUR_ALGS)
+        end
         #AT = Diagonal{T, Vector{T}}
         #TestSuite.test_schur(AT, m) # not supported yet
     end

test/testsuite/decompositions/schur.jl

@@ -9,6 +9,14 @@ function test_schur(T::Type, sz; kwargs...)
     end
 end
 
+function test_schur_algs(T::Type, sz, algs; kwargs...)
+    summary_str = testargs_summary(T, sz)
+    return @testset "schur algorithms $summary_str" begin
+        test_schur_full_algs(T, sz, algs; kwargs...)
+        test_schur_vals_algs(T, sz, algs; kwargs...)
+    end
+end
+
 function test_schur_full(
         T::Type, sz;
         atol::Real = 0, rtol::Real = precision(T),
@@ -34,6 +42,31 @@ function test_schur_full(
     end
 end
 
+function test_schur_full_algs(
+        T::Type, sz, algs;
+        atol::Real = 0, rtol::Real = precision(T),
+        kwargs...
+    )
+    summary_str = testargs_summary(T, sz)
+    return @testset "schur_full! algorithm $alg $summary_str" for alg in algs
+        A = instantiate_matrix(T, sz)
+        Ac = deepcopy(A)
+        Tc = isa(A, Diagonal) ? eltype(T) : complex(eltype(T))
+
+        TA, Z, vals = @testinferred schur_full(A; alg)
+        @test eltype(TA) == eltype(Z) == eltype(T)
+        @test eltype(vals) == Tc
+        @test isisometric(Z)
+        @test A * Z ≈ Z * TA
+
+        TA2, Z2, vals2 = @testinferred schur_full!(Ac, (TA, Z, vals); alg)
+        @test TA2 === TA
+        @test Z2 === Z
+        @test vals2 === vals
+        @test A * Z ≈ Z * TA
+    end
+end
+
 function test_schur_vals(
         T::Type, sz;
         atol::Real = 0, rtol::Real = precision(T),
@@ -55,3 +88,25 @@ function test_schur_vals(
         @test valsc ≈ eig_vals(A)
     end
 end
+
+function test_schur_vals_algs(
+        T::Type, sz, algs;
+        atol::Real = 0, rtol::Real = precision(T),
+        kwargs...
+    )
+    summary_str = testargs_summary(T, sz)
+    return @testset "schur_vals! algorithm $alg $summary_str" for alg in algs
+        A = instantiate_matrix(T, sz)
+        Ac = deepcopy(A)
+        Tc = isa(A, Diagonal) ? eltype(T) : complex(eltype(T))
+
+        valsc = @testinferred schur_vals(A; alg)
+        @test eltype(valsc) == Tc
+        @test valsc ≈ eig_vals(A)
+
+        valsc = similar(A, Tc, size(A, 1))
+        valsc = @testinferred schur_vals!(Ac, valsc; alg)
+        @test eltype(valsc) == Tc
+        @test valsc ≈ eig_vals(A)
+    end
+end