Almost

Author: kshyatt

test/testsuite/mooncake.jl

@@ -168,8 +168,10 @@ function test_mooncake(T::Type, sz; kwargs...)
         end
         test_mooncake_svd(T, sz; kwargs...)
         test_mooncake_polar(T, sz; kwargs...)
-        # doesn't work yet?
-        T <: Diagonal || test_mooncake_orthnull(T, sz; kwargs...)
+        # doesn't work for Diagonals yet?
+        if T <: Number
+            test_mooncake_orthnull(T, sz; kwargs...)
+        end
     end
 end
 
@@ -183,7 +185,8 @@ function test_mooncake_qr(
         A = instantiate_matrix(T, sz)
         @testset "qr_compact" begin
             QR, ΔQR = ad_qr_compact_setup(A)
-            Mooncake.TestUtils.test_rule(rng, qr_compact, A; is_primitive = false, mode = Mooncake.ReverseMode, atol = atol, rtol = rtol)
+            dQR = make_mooncake_tangent(ΔQR)
+            Mooncake.TestUtils.test_rule(rng, qr_compact, A; is_primitive = false, mode = Mooncake.ReverseMode, output_tangent = dQR, atol = atol, rtol = rtol)
             test_pullbacks_match(qr_compact!, qr_compact, A, QR, ΔQR)
         end
         @testset "qr_null" begin