Skip to content

Commit e19e9de

Browse files
committed
also remove supports_svd
1 parent ed99312 commit e19e9de

4 files changed

Lines changed: 0 additions & 9 deletions

File tree

ext/MatrixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ for f in (:geqrf!, :ungqr!, :unmqr!)
2828
@eval $f(::ROCSOLVER, args...) = YArocSOLVER.$f(args...)
2929
end
3030

31-
MatrixAlgebraKit.supports_svd(::ROCSOLVER, f::Symbol) = f in (:qr_iteration, :jacobi)
3231
MatrixAlgebraKit.supports_svd_full(::ROCSOLVER, f::Symbol) = f in (:qr_iteration, :jacobi)
3332

3433
function gesvd!(::ROCSOLVER, A::StridedROCMatrix, S::StridedROCVector, U::StridedROCMatrix, Vᴴ::StridedROCMatrix; kwargs...)

ext/MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ for f in (:geqrf!, :ungqr!, :unmqr!)
3333
@eval $f(::CUSOLVER, args...) = YACUSOLVER.$f(args...)
3434
end
3535

36-
MatrixAlgebraKit.supports_svd(::CUSOLVER, f::Symbol) = f in (:qr_iteration, :jacobi, :svd_polar)
3736
MatrixAlgebraKit.supports_svd_full(::CUSOLVER, f::Symbol) = f in (:qr_iteration, :jacobi, :svd_polar)
3837

3938
function gesvd!(::CUSOLVER, A::StridedCuMatrix, S::StridedCuVector, U::StridedCuMatrix, Vᴴ::StridedCuMatrix; kwargs...)

ext/MatrixAlgebraKitGenericLinearAlgebraExt.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ const GlaFloat = Union{BigFloat, Complex{BigFloat}}
1111
const GlaStridedVecOrMatrix{T <: GlaFloat} = Union{StridedVector{T}, StridedMatrix{T}}
1212
MatrixAlgebraKit.default_driver(::Type{<:QRIteration}, ::Type{TA}) where {TA <: GlaStridedVecOrMatrix} = GLA()
1313

14-
MatrixAlgebraKit.supports_svd(::GLA, f::Symbol) = f === :qr_iteration
1514
MatrixAlgebraKit.supports_svd_full(::GLA, f::Symbol) = f === :qr_iteration
1615

1716
function MatrixAlgebraKit.default_svd_algorithm(

src/implementations/svd.jl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,6 @@ for (f, f_lapack!, Alg) in (
194194
# Implementation
195195
@eval begin
196196
function $f_svd!(driver::Driver, A, U, S, Vᴴ; fixgauge::Bool = true, kwargs...)
197-
supports_svd(driver, $(QuoteNode(f))) ||
198-
throw(ArgumentError(LazyString("driver ", driver, " does not provide `$($(QuoteNode(f_lapack!)))`")))
199197
isempty(A) && return one!(U), zero!(S), one!(Vᴴ)
200198
$f_lapack!(driver, A, diagview(S), U, Vᴴ; kwargs...)
201199
fixgauge && gaugefix!(svd_compact!, U, Vᴴ)
@@ -214,8 +212,6 @@ for (f, f_lapack!, Alg) in (
214212
return U, S, Vᴴ
215213
end
216214
function $f_svd_vals!(driver::Driver, A, S; fixgauge::Bool = true, kwargs...)
217-
supports_svd(driver, $(QuoteNode(f))) ||
218-
throw(ArgumentError(LazyString("driver ", driver, " does not provide `$($(QuoteNode(f_lapack!)))`")))
219215
isempty(A) && return zero!(S)
220216
U, Vᴴ = similar(A, (0, 0)), similar(A, (0, 0))
221217
$f_lapack!(driver, A, S, U, Vᴴ; kwargs...)
@@ -224,8 +220,6 @@ for (f, f_lapack!, Alg) in (
224220
end
225221
end
226222

227-
supports_svd(::Driver, ::Symbol) = false
228-
supports_svd(::LAPACK, f::Symbol) = f in (:safe_divide_and_conquer, :divide_and_conquer, :qr_iteration, :bisection, :jacobi)
229223
supports_svd_full(::Driver, ::Symbol) = false
230224
supports_svd_full(::LAPACK, f::Symbol) = f in (:safe_divide_and_conquer, :divide_and_conquer, :qr_iteration)
231225

0 commit comments

Comments
 (0)