Skip to content

Commit e22b2cf

Browse files
lkdvoslkdvos
committed
rename dogaugefix to do_gauge_fix 
1 parent 4e41998 commit e22b2cf

5 files changed

Lines changed: 24 additions & 24 deletions

File tree

‎ext/MatrixAlgebraKitGenericLinearAlgebraExt.jl‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ function MatrixAlgebraKit.svd_compact!(A::AbstractMatrix, USVᴴ, alg::GLA_QRIte
1717
F = svd!(A)
1818
U, S, Vᴴ = F.U, Diagonal(F.S), F.Vt
1919

20-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
21-
dogaugefix && gaugefix!(svd_compact!, U, Vᴴ)
20+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
21+
do_gauge_fix && gaugefix!(svd_compact!, U, Vᴴ)
2222

2323
return U, S, Vᴴ
2424
end
@@ -29,8 +29,8 @@ function MatrixAlgebraKit.svd_full!(A::AbstractMatrix, USVᴴ, alg::GLA_QRIterat
2929
S = MatrixAlgebraKit.zero!(similar(F.S, (size(U, 2), size(Vᴴ, 1))))
3030
diagview(S) .= F.S
3131

32-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
33-
dogaugefix && gaugefix!(svd_full!, U, Vᴴ)
32+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
33+
do_gauge_fix && gaugefix!(svd_full!, U, Vᴴ)
3434

3535
return U, S, Vᴴ
3636
end

‎src/implementations/eig.jl‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ function eig_full!(A::AbstractMatrix, DV, alg::LAPACK_EigAlgorithm)
8282
check_input(eig_full!, A, DV, alg)
8383
D, V = DV
8484

85-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
85+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
8686
lapack_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:gaugefix,)})
8787

8888
if alg isa LAPACK_Simple
@@ -93,7 +93,7 @@ function eig_full!(A::AbstractMatrix, DV, alg::LAPACK_EigAlgorithm)
9393
YALAPACK.geevx!(A, D.diag, V; lapack_kwargs...)
9494
end
9595

96-
dogaugefix && (V = gaugefix!(eig_full!, V))
96+
do_gauge_fix && (V = gaugefix!(eig_full!, V))
9797

9898
return D, V
9999
end
@@ -145,15 +145,15 @@ function eig_full!(A::AbstractMatrix, DV, alg::GPU_EigAlgorithm)
145145
check_input(eig_full!, A, DV, alg)
146146
D, V = DV
147147

148-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
148+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
149149
lapack_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:gaugefix,)})
150150

151151
if alg isa GPU_Simple
152152
isempty(lapack_kwargs) || @warn "invalid keyword arguments for GPU_Simple"
153153
_gpu_geev!(A, D.diag, V)
154154
end
155155

156-
dogaugefix && (V = gaugefix!(eig_full!, V))
156+
do_gauge_fix && (V = gaugefix!(eig_full!, V))
157157

158158
return D, V
159159
end

‎src/implementations/eigh.jl‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ function eigh_full!(A::AbstractMatrix, DV, alg::LAPACK_EighAlgorithm)
9292
D, V = DV
9393
Dd = D.diag
9494

95-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
95+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
9696
lapack_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:gaugefix,)})
9797

9898
if alg isa LAPACK_MultipleRelativelyRobustRepresentations
@@ -105,7 +105,7 @@ function eigh_full!(A::AbstractMatrix, DV, alg::LAPACK_EighAlgorithm)
105105
YALAPACK.heevx!(A, Dd, V; lapack_kwargs...)
106106
end
107107

108-
dogaugefix && (V = gaugefix!(eigh_full!, V))
108+
do_gauge_fix && (V = gaugefix!(eigh_full!, V))
109109

110110
return D, V
111111
end
@@ -168,7 +168,7 @@ function eigh_full!(A::AbstractMatrix, DV, alg::GPU_EighAlgorithm)
168168
D, V = DV
169169
Dd = D.diag
170170

171-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
171+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
172172
lapack_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:gaugefix,)})
173173

174174
if alg isa GPU_Jacobi
@@ -183,7 +183,7 @@ function eigh_full!(A::AbstractMatrix, DV, alg::GPU_EighAlgorithm)
183183
throw(ArgumentError("Unsupported eigh algorithm"))
184184
end
185185

186-
dogaugefix && (V = gaugefix!(eigh_full!, V))
186+
do_gauge_fix && (V = gaugefix!(eigh_full!, V))
187187

188188
return D, V
189189
end

‎src/implementations/gen_eig.jl‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function gen_eig_full!(A::AbstractMatrix, B::AbstractMatrix, WV, alg::LAPACK_Eig
5858
check_input(gen_eig_full!, A, B, WV, alg)
5959
W, V = WV
6060

61-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
61+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
6262
lapack_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:gaugefix,)})
6363

6464
if alg isa LAPACK_Simple
@@ -69,7 +69,7 @@ function gen_eig_full!(A::AbstractMatrix, B::AbstractMatrix, WV, alg::LAPACK_Eig
6969
throw(ArgumentError("LAPACK_Expert is not supported for ggev"))
7070
end
7171

72-
dogaugefix && (V = gaugefix!(gen_eig_full!, V))
72+
do_gauge_fix && (V = gaugefix!(gen_eig_full!, V))
7373

7474
return W, V
7575
end

‎src/implementations/svd.jl‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ function svd_full!(A::AbstractMatrix, USVᴴ, alg::LAPACK_SVDAlgorithm)
120120
return USVᴴ
121121
end
122122

123-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
123+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
124124
lapack_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:gaugefix,)})
125125

126126
if alg isa LAPACK_QRIteration
@@ -144,7 +144,7 @@ function svd_full!(A::AbstractMatrix, USVᴴ, alg::LAPACK_SVDAlgorithm)
144144
S[i, 1] = zero(eltype(S))
145145
end
146146

147-
dogaugefix && gaugefix!(svd_full!, U, Vᴴ)
147+
do_gauge_fix && gaugefix!(svd_full!, U, Vᴴ)
148148

149149
return USVᴴ
150150
end
@@ -153,7 +153,7 @@ function svd_compact!(A::AbstractMatrix, USVᴴ, alg::LAPACK_SVDAlgorithm)
153153
check_input(svd_compact!, A, USVᴴ, alg)
154154
U, S, Vᴴ = USVᴴ
155155

156-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
156+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
157157
lapack_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:gaugefix,)})
158158

159159
if alg isa LAPACK_QRIteration
@@ -174,7 +174,7 @@ function svd_compact!(A::AbstractMatrix, USVᴴ, alg::LAPACK_SVDAlgorithm)
174174
throw(ArgumentError("Unsupported SVD algorithm"))
175175
end
176176

177-
dogaugefix && gaugefix!(svd_compact!, U, Vᴴ)
177+
do_gauge_fix && gaugefix!(svd_compact!, U, Vᴴ)
178178

179179
return USVᴴ
180180
end
@@ -336,7 +336,7 @@ function svd_full!(A::AbstractMatrix, USVᴴ, alg::GPU_SVDAlgorithm)
336336
return USVᴴ
337337
end
338338

339-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
339+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
340340
lapack_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:gaugefix,)})
341341

342342
if alg isa GPU_QRIteration
@@ -352,7 +352,7 @@ function svd_full!(A::AbstractMatrix, USVᴴ, alg::GPU_SVDAlgorithm)
352352
diagview(S) .= view(S, 1:minmn, 1)
353353
view(S, 2:minmn, 1) .= zero(eltype(S))
354354

355-
dogaugefix && gaugefix!(svd_full!, U, Vᴴ)
355+
do_gauge_fix && gaugefix!(svd_full!, U, Vᴴ)
356356

357357
return USVᴴ
358358
end
@@ -362,8 +362,8 @@ function svd_trunc!(A::AbstractMatrix, USVᴴ, alg::TruncatedAlgorithm{<:GPU_Ran
362362
U, S, Vᴴ = USVᴴ
363363
_gpu_Xgesvdr!(A, S.diag, U, Vᴴ; alg.alg.kwargs...)
364364

365-
dogaugefix = get(alg.alg.kwargs, :gaugefix, true)::Bool
366-
dogaugefix && gaugefix!(svd_trunc!, U, Vᴴ)
365+
do_gauge_fix = get(alg.alg.kwargs, :gaugefix, true)::Bool
366+
do_gauge_fix && gaugefix!(svd_trunc!, U, Vᴴ)
367367

368368
# TODO: make sure that truncation is based on maxrank, otherwise this might be wrong
369369
USVᴴtrunc, ind = truncate(svd_trunc!, (U, S, Vᴴ), alg.trunc)
@@ -377,7 +377,7 @@ function svd_compact!(A::AbstractMatrix, USVᴴ, alg::GPU_SVDAlgorithm)
377377
check_input(svd_compact!, A, USVᴴ, alg)
378378
U, S, Vᴴ = USVᴴ
379379

380-
dogaugefix = get(alg.kwargs, :gaugefix, true)::Bool
380+
do_gauge_fix = get(alg.kwargs, :gaugefix, true)::Bool
381381
lapack_kwargs = Base.structdiff(alg.kwargs, NamedTuple{(:gaugefix,)})
382382

383383
if alg isa GPU_QRIteration
@@ -391,7 +391,7 @@ function svd_compact!(A::AbstractMatrix, USVᴴ, alg::GPU_SVDAlgorithm)
391391
throw(ArgumentError("Unsupported SVD algorithm"))
392392
end
393393

394-
dogaugefix && gaugefix!(svd_compact!, U, Vᴴ)
394+
do_gauge_fix && gaugefix!(svd_compact!, U, Vᴴ)
395395

396396
return USVᴴ
397397
end

0 commit comments

Comments
 (0)