Small changes to unblock TensorKit svd

Author: kshyatt

ext/MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl

@@ -22,7 +22,7 @@ function MatrixAlgebraKit.default_lq_algorithm(::Type{T}; kwargs...) where {TT<:
     return LQViaTransposedQR(qr_alg)
 end
 function MatrixAlgebraKit.default_svd_algorithm(::Type{T}; kwargs...) where {TT<:BlasFloat, T<:StridedCuMatrix{TT}}
-    return CUSOLVER_QRIteration(; kwargs...)
+    return CUSOLVER_Jacobi(; kwargs...)
 end
 function MatrixAlgebraKit.default_eig_algorithm(::Type{T}; kwargs...) where {TT<:BlasFloat, T<:StridedCuMatrix{TT}}
     return CUSOLVER_Simple(; kwargs...)

src/implementations/polar.jl

@@ -50,8 +50,9 @@ function left_polar!(A::AbstractMatrix, WP, alg::PolarViaSVD)
     U, S, Vᴴ = svd_compact!(A, alg.svdalg)
     W, P = WP
     W = mul!(W, U, Vᴴ)
-    S .= sqrt.(S)
-    SsqrtVᴴ = lmul!(S, Vᴴ)
+    @. S = sqrt(S)
+    @. Vᴴ *= S 
+    SsqrtVᴴ = Vᴴ
     P = mul!(P, SsqrtVᴴ', SsqrtVᴴ)
     return (W, P)
 end
@@ -60,8 +61,9 @@ function right_polar!(A::AbstractMatrix, PWᴴ, alg::PolarViaSVD)
     U, S, Vᴴ = svd_compact!(A, alg.svdalg)
     P, Wᴴ = PWᴴ
     Wᴴ = mul!(Wᴴ, U, Vᴴ)
-    S .= sqrt.(S)
-    USsqrt = rmul!(U, S)
+    @. S = sqrt(S)
+    @. U *= S
+    USsqrt = U
     P = mul!(P, USsqrt, USsqrt')
     return (P, Wᴴ)
 end

src/implementations/svd.jl

@@ -288,7 +288,7 @@ function MatrixAlgebraKit.svd_compact!(A::AbstractMatrix, USVᴴ, alg::GPU_SVDAl
     U, S, Vᴴ = USVᴴ
     if alg isa GPU_QRIteration
         isempty(alg.kwargs) ||
-            throw(ArgumentError("GPU_QRIteration does not accept any keyword arguments"))
+            @warn "GPU_QRIteration does not accept any keyword arguments"
         _gpu_gesvd!(A, S.diag, U, Vᴴ)
     elseif alg isa GPU_SVDPolar
         _gpu_Xgesvdp!(A, S.diag, U, Vᴴ; alg.kwargs...)