Split up tests and address other comments

Author: kshyatt

src/interface/orthnull.jl

@@ -443,6 +443,7 @@ left_orth_alg(alg::LeftOrthAlgorithm) = alg
 left_orth_alg(alg::QRAlgorithms) = LeftOrthViaQR(alg)
 left_orth_alg(alg::PolarAlgorithms) = LeftOrthViaPolar(alg)
 left_orth_alg(alg::SVDAlgorithms) = LeftOrthViaSVD(alg)
+left_orth_alg(alg::DiagonalAlgorithm) = LeftOrthViaSVD(alg)
 left_orth_alg(alg::TruncatedAlgorithm{<:SVDAlgorithms}) = LeftOrthViaSVD(alg)
 
 """
@@ -478,6 +479,7 @@ right_orth_alg(alg::RightOrthAlgorithm) = alg
 right_orth_alg(alg::LQAlgorithms) = RightOrthViaLQ(alg)
 right_orth_alg(alg::PolarAlgorithms) = RightOrthViaPolar(alg)
 right_orth_alg(alg::SVDAlgorithms) = RightOrthViaSVD(alg)
+right_orth_alg(alg::DiagonalAlgorithm) = RightOrthViaSVD(alg)
 right_orth_alg(alg::TruncatedAlgorithm{<:SVDAlgorithms}) = RightOrthViaSVD(alg)
 
 """

test/orthnull.jl

@@ -18,17 +18,17 @@ for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
     TestSuite.seed_rng!(123)
     if T ∈ BLASFloats
         if CUDA.functional()
-            TestSuite.test_orthnull(CuMatrix{T}, (m, n))
-            n == m && TestSuite.test_orthnull(Diagonal{T, CuVector{T}}, m)
+            TestSuite.test_orthnull(CuMatrix{T}, (m, n); test_nullity = false)
+            n == m && TestSuite.test_orthnull(Diagonal{T, CuVector{T}}, m; test_orthnull = false)
         end
         if AMDGPU.functional()
-            TestSuite.test_orthnull(ROCMatrix{T}, (m, n))
-            n == m && TestSuite.test_orthnull(Diagonal{T, ROCVector{T}}, m)
+            TestSuite.test_orthnull(ROCMatrix{T}, (m, n); test_nullity = false)
+            n == m && TestSuite.test_orthnull(Diagonal{T, ROCVector{T}}, m; test_orthnull = false)
         end
     end
     if !is_buildkite
         TestSuite.test_orthnull(T, (m, n))
-        #AT = Diagonal{T, Vector{T}}
-        #TestSuite.test_orthnull(AT, m) # not supported
+        AT = Diagonal{T, Vector{T}}
+        TestSuite.test_orthnull(AT, m; test_orthnull = false)
     end
 end

test/testsuite/TestSuite.jl

@@ -11,7 +11,7 @@ module TestSuite
 using Test
 using MatrixAlgebraKit
 using MatrixAlgebraKit: diagview
-using LinearAlgebra: Diagonal, norm, istriu, istril
+using LinearAlgebra: Diagonal, norm, istriu, istril, I
 using Random, StableRNGs
 using AMDGPU, CUDA
 
@@ -69,6 +69,13 @@ is_positive(alg::MatrixAlgebraKit.ROCSOLVER_HouseholderQR) = alg.positive
 is_positive(alg::MatrixAlgebraKit.LQViaTransposedQR) = is_positive(alg.qr_alg)
 is_pivoted(alg::MatrixAlgebraKit.LQViaTransposedQR) = is_pivoted(alg.qr_alg)
 
+isleftcomplete(V, N) = V * V' + N * N' ≈ I
+isleftcomplete(V::AnyCuMatrix, N::AnyCuMatrix) = isleftcomplete(collect(V), collect(N))
+isleftcomplete(V::AnyROCMatrix, N::AnyROCMatrix) = isleftcomplete(collect(V), collect(N))
+isrightcomplete(Vᴴ, Nᴴ) = Vᴴ' * Vᴴ + Nᴴ' * Nᴴ ≈ I
+isrightcomplete(V::AnyCuMatrix, N::AnyCuMatrix) = isrightcomplete(collect(V), collect(N))
+isrightcomplete(V::AnyROCMatrix, N::AnyROCMatrix) = isrightcomplete(collect(V), collect(N))
+
 include("qr.jl")
 include("lq.jl")
 include("polar.jl")