Add some tests

Author: lkdvos

test/eig.jl

@@ -52,11 +52,18 @@ end
         D2, V2 = @constinferred eig_trunc(A; alg, trunc)
         @test length(diagview(D2)) == r
         @test A * V2 ≈ V2 * D2
+        
+        trunc = truncerror(s * norm(@view(D₀[r+1:end])))
+        D3, V3 = @constinferred eig_trunc(A; alg, trunc)
+        @test length(diagview(D3)) == r
+        @test A * V3 ≈ V3 * D3
 
         # trunctol keeps order, truncrank might not
         # test for same subspace
         @test V1 * ((V1' * V1) \ (V1' * V2)) ≈ V2
         @test V2 * ((V2' * V2) \ (V2' * V1)) ≈ V1
+        @test V1 * ((V1' * V1) \ (V1' * V3)) ≈ V3
+        @test V3 * ((V3' * V3) \ (V3' * V1)) ≈ V1
     end
 end
 
@@ -70,6 +77,10 @@ end
     D2, V2 = @constinferred eig_trunc(A; alg)
     @test diagview(D2) ≈ diagview(D)[1:2] rtol = sqrt(eps(real(T)))
     @test_throws ArgumentError eig_trunc(A; alg, trunc=(; maxrank=2))
+    
+    alg = TruncatedAlgorithm(LAPACK_Simple(), truncerror(0.2))
+    D3, V3 = @constinferred eig_trunc(A; alg)
+    @test diagview(D3) ≈ diagview(D)[1:2] rtol = sqrt(eps(real(T)))
 end
 
 @testset "eig for Diagonal{$T}" for T in BLASFloats

test/eigh.jl

@@ -57,10 +57,17 @@ end
         @test length(diagview(D2)) == r
         @test isisometry(V2)
         @test A * V2 ≈ V2 * D2
+        
+        trunc = truncerror(s * norm(@view(D₀[r+1:end])))
+        D3, V3 = @constinferred eigh_trunc(A; alg, trunc)
+        @test length(diagview(D3)) == r
+        @test A * V3 ≈ V3 * D3
 
         # test for same subspace
         @test V1 * (V1' * V2) ≈ V2
         @test V2 * (V2' * V1) ≈ V1
+        @test V1 * (V1' * V3) ≈ V3
+        @test V3 * (V3' * V1) ≈ V1
     end
 end
 
@@ -75,6 +82,10 @@ end
     D2, V2 = @constinferred eigh_trunc(A; alg)
     @test diagview(D2) ≈ diagview(D)[1:2] rtol = sqrt(eps(real(T)))
     @test_throws ArgumentError eigh_trunc(A; alg, trunc=(; maxrank=2))
+    
+    alg = TruncatedAlgorithm(LAPACK_Simple(), truncerror(0.2))
+    D3, V3 = @constinferred eigh_trunc(A; alg)
+    @test diagview(D3) ≈ diagview(D)[1:2] rtol = sqrt(eps(real(T)))
 end
 
 @testset "eigh for Diagonal{$T}" for T in BLASFloats

test/svd.jl

@@ -120,6 +120,13 @@ end
             @test U1 ≈ U2
             @test S1 ≈ S2
             @test V1ᴴ ≈ V2ᴴ
+
+            trunc = truncerr(s * norm(@view(S₀[(r + 1):end])))
+            U3, S3, V3ᴴ = @constinferred svd_trunc(A; alg, trunc)
+            @test length(S3.diag) == r
+            @test U1 ≈ U3
+            @test S1 ≈ S3
+            @test V1ᴴ ≈ V3ᴴ
         end
     end
 end

test/truncate.jl

@@ -69,4 +69,8 @@ using MatrixAlgebraKit: NoTruncation, TruncationIntersection, TruncationKeepAbov
                      TruncationKeepBelow(0.2, 0))
         @test @constinferred(findtruncated(values, strategy)) == [1]
     end
+    for strategy in (truncerror(; atol=0.2, rtol=0),)
+        @test issetequal(@constinferred(findtruncated(values, strategy)), 2:5)
+        @test @constinferred(findtruncated_sorted(sort(values; by=abs, rev=true), strategy)) == 1:4
+    end
 end