Some small fixes again

Author: kshyatt

ext/MatrixAlgebraKitEnzymeExt/MatrixAlgebraKitEnzymeExt.jl

@@ -275,6 +275,11 @@ for f in (:svd_compact!, :svd_full!)
             ) where {RT, TA}
             $f(A.val, USVᴴ.val, alg.val)
             if !isa(A, Const)
+                if $(f == svd_compact!) 
+                    make_zero!(USVᴴ.dval[2].diag)
+                else
+                    make_zero!(USVᴴ.dval[2])
+                end
                 !isa(USVᴴ, Const) && svd_pushforward!(A.dval, A.val, USVᴴ.val, USVᴴ.dval)
                 make_zero!(A.dval)
             end

src/pushforwards/svd.jl

@@ -7,7 +7,7 @@ function svd_pushforward!(ΔA, A, USVᴴ, ΔUSVᴴ, ind = Colon(); rank_atol = d
     ΔU, ΔS, ΔVᴴ = ΔUSVᴴ
     r = svd_rank(S; rank_atol)
 
-    vΔS = view(ΔS, 1:r, 1:r)
+    vΔS = view(diagview(ΔS), 1:r)
 
     vU = view(U, :, 1:r)
     vS = view(S, 1:r)
@@ -17,7 +17,7 @@ function svd_pushforward!(ΔA, A, USVᴴ, ΔUSVᴴ, ind = Colon(); rank_atol = d
     # compact region
     vV = adjoint(vVᴴ)
     UΔAV = vU' * ΔA * vV
-    copyto!(diagview(vΔS), real.(diagview(UΔAV)))
+    copyto!(vΔS, real.(diagview(UΔAV)))
     F = inv_safe.(transpose(vS) .- vS)
     G = inv_safe.(transpose(vS) .+ vS)
     hUΔAV = F .* (UΔAV + UΔAV') ./ 2

test/enzyme/svd.jl

@@ -3,7 +3,7 @@ using Test
 using LinearAlgebra: Diagonal
 using CUDA, AMDGPU
 
-BLASFloats = (Float32, ComplexF64) # full suite is too expensive on CI
+BLASFloats = (Float64, ComplexF64) # full suite is too expensive on CI
 GenericFloats = ()
 @isdefined(TestSuite) || include("../testsuite/TestSuite.jl")
 using .TestSuite