Comments

Author: kshyatt

ext/MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl

@@ -13,8 +13,6 @@ using CUDA: i32
 using LinearAlgebra
 using LinearAlgebra: BlasFloat
 
-using CUDA: i32
-
 include("yacusolver.jl")
 
 function MatrixAlgebraKit.default_qr_algorithm(::Type{T}; kwargs...) where {TT <: BlasFloat, T <: StridedCuMatrix{TT}}

src/implementations/eig.jl

@@ -137,7 +137,7 @@ function eig_full!(A::AbstractMatrix, DV, alg::GPU_EigAlgorithm)
     D, V = DV
     if alg isa GPU_Simple
         isempty(alg.kwargs) ||
-            throw(ArgumentError("GPU_Simple (geev) does not accept any keyword arguments"))
+            @warn "GPU_Simple (geev) does not accept any keyword arguments"
         _gpu_geev!(A, D.diag, V)
     end
     # TODO: make this controllable using a `gaugefix` keyword argument
@@ -149,9 +149,8 @@ function eig_vals!(A::AbstractMatrix, D, alg::GPU_EigAlgorithm)
     check_input(eig_vals!, A, D, alg)
     V = similar(A, complex(eltype(A)), (size(A, 1), 0))
     if alg isa GPU_Simple
-        # TODO filter out nothing kwargs
-        #isempty(alg.kwargs) ||
-        #    throw(ArgumentError("GPU_Simple (geev) does not accept any keyword arguments"))
+        isempty(alg.kwargs) ||
+            @warn "GPU_Simple (geev) does not accept any keyword arguments"
         _gpu_geev!(A, D, V)
     end
     return D

test/cuda/projections.jl

@@ -12,7 +12,7 @@ const BLASFloats = (Float32, Float64, ComplexF32, ComplexF64)
     m = 54
     noisefactor = eps(real(T))^(3 / 4)
     for alg in (NativeBlocked(blocksize = 16), NativeBlocked(blocksize = 32), NativeBlocked(blocksize = 64))
-        A  = CuArray(randn(rng, T, m, m))
+        A = CuArray(randn(rng, T, m, m))
         Ah = (A + A') / 2
         Aa = (A - A') / 2
         Ac = copy(A)
@@ -69,7 +69,7 @@ end
             # test that W is closer to A then any other isometry
             for k in 1:10
                 δA = CuArray(randn(rng, T, m, n))
-                W  = project_isometric(A, alg)
+                W = project_isometric(A, alg)
                 W2 = project_isometric(A + δA / 100, alg)
                 @test norm(A - W2) > norm(A - W)
             end