Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Member
Author
|
@kshyatt , rescaling the eigenvalue distribution by a factor of 10 seems to solve the AD chainrules problems (for now) 🥳 . |
lkdvos
approved these changes
Dec 29, 2025
Member
lkdvos
left a comment
There was a problem hiding this comment.
Out of curiosity, did you find these YALAPACK bugs through the new JET report? Otherwise we might have to also hunt for some extra test coverage at some point
Member
Author
|
Yes this is based on the new JET reports 😄 . However, it has issues with the pattern if condition
new_variable =
else
# no declaration/definition of new_variable
end
# more code
if same_condition_as_before
do_something(new_variable)
endAnd there also seem to be some compatibility issues with Julia LTS and newest JET. |
Member
Author
|
Testing for all possible error messages is really a nuisance. Also, if there is a mistake in there, you will still get an error, only a less informative one 😄 . |
lkdvos
referenced
this pull request
Jan 8, 2026
* Bump version * update changelog --------- Co-authored-by: Lukas Devos <ldevos98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.