Skip to content

Fix ishermitian for zero-matrix #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 3 commits into from
Dec 17, 2025
Merged

Fix ishermitian for zero-matrix #121

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5172247
check error with ≤
ogauthe Dec 17, 2025
5891ac0
add test
ogauthe Dec 17, 2025
eb1eef8
runic
ogauthe Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/common/matrixproperties.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,15 @@ function strided_ishermitian_approx(
for j in 1:blocksize:n
jb = min(blocksize, n - j + 1)
ϵ² += _ishermitian_approx_diag(view(A, j:(j + jb - 1), j:(j + jb - 1)), anti)
ϵ² < ϵ²max || return false
ϵ² ≤ ϵ²max || return false
for i in 1:blocksize:(j - 1)
ib = blocksize
ϵ² += 2 * _ishermitian_approx_offdiag(
view(A, i:(i + ib - 1), j:(j + jb - 1)),
view(A, j:(j + jb - 1), i:(i + ib - 1)),
anti
)
ϵ² < ϵ²max || return false
ϵ² ≤ ϵ²max || return false
end
end
return true
Expand Down