Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
kshyatt
reviewed
Dec 19, 2025
kshyatt
reviewed
Dec 19, 2025
kshyatt
reviewed
Dec 19, 2025
kshyatt
reviewed
Dec 19, 2025
kshyatt
approved these changes
Dec 19, 2025
Member
kshyatt
left a comment
kshyatt
left a comment
There was a problem hiding this comment.
LGTM, just left some nitpicky comments
kshyatt
reviewed
Dec 19, 2025
| function stabilize_eigvals!(D::AbstractVector) | ||
| absD = abs.(D) | ||
| p = invperm(sortperm(absD)) # rank of abs(D) | ||
| # account for exact degeneracies in absolute value when having complex conjugate pairs |
Member
There was a problem hiding this comment.
Great! This will help us a lot if we have to revisit in 6 months, I think.
lkdvos
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to remove all (near) degeneracies in matrices that we will use for the AD of the eigenvalue decomposition, thereby hopefully stabilizing the tests.
I also made some progress with the case of degeneracies, for which I will make a separate PR with some hand written tests.