Skip to content

Run trunc tests with Float32 thanks to new Enzyme - #187

Merged
kshyatt merged 1 commit into
mainfrom
ksh/enz32
Mar 18, 2026
Merged

Run trunc tests with Float32 thanks to new Enzyme#187
kshyatt merged 1 commit into
mainfrom
ksh/enz32

Conversation

@kshyatt

@kshyatt kshyatt commented Mar 13, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Mar 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jutho

Jutho commented Mar 15, 2026

Copy link
Copy Markdown
Member

I am surprised this works; I actually moved also the Mooncake tests to Float64 after some issues in #180 .

@kshyatt

kshyatt commented Mar 16, 2026

Copy link
Copy Markdown
Member Author

Could it be the custom finite differences method Enzyme is using for fp32?

@kshyatt

kshyatt commented Mar 17, 2026

Copy link
Copy Markdown
Member Author

Anyone have objections to me merging this?

@Jutho

Jutho commented Mar 17, 2026

Copy link
Copy Markdown
Member

Not really, though as mentioned, I actually moved LQ and QR tests for Mooncake and Enzyme from Float32 to Float64, so this is moving in the opposite direction of consistency.

@Jutho

Jutho commented Mar 17, 2026

Copy link
Copy Markdown
Member

Maybe worth testing again if that change of mine was really necessary, or resulting from an underlying problem that I only fixed afterwards?

@kshyatt

kshyatt commented Mar 17, 2026

Copy link
Copy Markdown
Member Author

Let me check that also, then

@kshyatt

kshyatt commented Mar 17, 2026

Copy link
Copy Markdown
Member Author

I see the failures locally too. Maybe we can test both Float32 and Float64 for these Enzyme + truncation tests, considering they now take much less time, and it was previously erroring out in a horrible way?

@Jutho

Jutho commented Mar 17, 2026

Copy link
Copy Markdown
Member

I am fine with any suggestion. I should probably revisit the QR/LQ tests, since I would think that the eig / svd tests are more sensitive to numerical noise than QR/LQ, so if former manage to work for Float32, then why not the latter.

@kshyatt
kshyatt merged commit 6d52436 into main Mar 18, 2026
8 of 9 checks passed
@kshyatt
kshyatt deleted the ksh/enz32 branch March 18, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants