Skip to content

Ensure no sharing of data in LQ gauge fixing #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 1 commit into from
Apr 27, 2026
Merged

Ensure no sharing of data in LQ gauge fixing #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/implementations/lq.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,10 @@ function lq_householder!(
end

if computeL
L̃ = lowertriangular!(view(A, axes(L)...))
positive && gaugefix!(lq_householder!, L̃, Q, diagview(A))
copyto!(L, L̃)
# we need to first copy then gaugefix - avoiding aliasing between L and Ld for broadcast
Ld = diagview(A)
copyto!(L, lowertriangular!(view(A, axes(L)...)))
positive && gaugefix!(lq_householder!, L, Q, Ld)
else
gaugefix!(lq_householder!, nothing, Q, diagview(A))
end
Expand Down
Loading