From 76ff5c9a0afdeddf16ed8e64dad09b55fea0b13d Mon Sep 17 00:00:00 2001 From: Katharine Hyatt Date: Thu, 14 Aug 2025 06:19:25 -0400 Subject: [PATCH] Resolve comments --- ext/MatrixAlgebraKitAMDGPUExt/yarocsolver.jl | 3 --- test/amd/lq.jl | 2 +- test/amd/qr.jl | 2 +- test/amd/svd.jl | 2 +- test/cuda/lq.jl | 2 +- test/cuda/qr.jl | 2 +- test/cuda/svd.jl | 2 +- test/cuda/utilities.jl | 3 --- test/{amd => }/utilities.jl | 0 9 files changed, 6 insertions(+), 12 deletions(-) delete mode 100644 test/cuda/utilities.jl rename test/{amd => }/utilities.jl (100%) diff --git a/ext/MatrixAlgebraKitAMDGPUExt/yarocsolver.jl b/ext/MatrixAlgebraKitAMDGPUExt/yarocsolver.jl index 97c8e6ee3..ad1df695b 100644 --- a/ext/MatrixAlgebraKitAMDGPUExt/yarocsolver.jl +++ b/ext/MatrixAlgebraKitAMDGPUExt/yarocsolver.jl @@ -164,9 +164,6 @@ for (fname, elty, relty) in AMDGPU.unsafe_free!(dev_residual) AMDGPU.unsafe_free!(dev_n_sweeps) - #if jobvt == rocSOLVER.rocblas_svect_singular || jobvt == rocSOLVER.rocblas_svect_all - # adjoint!(Vᴴ, Ṽ) - #end return U, S, Vᴴ end end diff --git a/test/amd/lq.jl b/test/amd/lq.jl index 5a5f53408..e564ed4eb 100644 --- a/test/amd/lq.jl +++ b/test/amd/lq.jl @@ -5,7 +5,7 @@ using TestExtras using StableRNGs using AMDGPU -include("utilities.jl") +include(joinpath("..", "utilities.jl")) @testset "lq_compact! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64) rng = StableRNG(123) diff --git a/test/amd/qr.jl b/test/amd/qr.jl index 694963b5b..35c4019b1 100644 --- a/test/amd/qr.jl +++ b/test/amd/qr.jl @@ -5,7 +5,7 @@ using TestExtras using StableRNGs using AMDGPU -include("utilities.jl") +include(joinpath("..", "utilities.jl")) @testset "qr_compact! and qr_null! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64) diff --git a/test/amd/svd.jl b/test/amd/svd.jl index 8442b7ccf..ecf79b003 100644 --- a/test/amd/svd.jl +++ b/test/amd/svd.jl @@ -6,7 +6,7 @@ using TestExtras using StableRNGs using AMDGPU -include("utilities.jl") +include(joinpath("..", "utilities.jl")) @testset "svd_compact! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64) rng = StableRNG(123) diff --git a/test/cuda/lq.jl b/test/cuda/lq.jl index cc1def1ce..4ce111eb1 100644 --- a/test/cuda/lq.jl +++ b/test/cuda/lq.jl @@ -5,7 +5,7 @@ using TestExtras using StableRNGs using CUDA -include("utilities.jl") +include(joinpath("..", "utilities.jl")) @testset "lq_compact! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64) rng = StableRNG(123) diff --git a/test/cuda/qr.jl b/test/cuda/qr.jl index 4ada45652..c0f3692aa 100644 --- a/test/cuda/qr.jl +++ b/test/cuda/qr.jl @@ -5,7 +5,7 @@ using TestExtras using StableRNGs using CUDA -include("utilities.jl") +include(joinpath("..", "utilities.jl")) @testset "qr_compact! and qr_null! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64) diff --git a/test/cuda/svd.jl b/test/cuda/svd.jl index 66098c4ba..913f77db6 100644 --- a/test/cuda/svd.jl +++ b/test/cuda/svd.jl @@ -6,7 +6,7 @@ using TestExtras using StableRNGs using CUDA -include("utilities.jl") +include(joinpath("..", "utilities.jl")) @testset "svd_compact! for T = $T" for T in (Float32, Float64, ComplexF32, ComplexF64) rng = StableRNG(123) diff --git a/test/cuda/utilities.jl b/test/cuda/utilities.jl deleted file mode 100644 index 61518b556..000000000 --- a/test/cuda/utilities.jl +++ /dev/null @@ -1,3 +0,0 @@ -function isapproxone(A) - return (size(A, 1) == size(A, 2)) && (A ≈ MatrixAlgebraKit.one!(similar(A))) -end diff --git a/test/amd/utilities.jl b/test/utilities.jl similarity index 100% rename from test/amd/utilities.jl rename to test/utilities.jl