Skip to content

Pullback rules for truncation methods #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 11 commits into from
Sep 29, 2025
Merged

Pullback rules for truncation methods #53

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
39e9ce0
prepare pullback rules for truncation
Jutho Sep 10, 2025
bf91b1d
some updates
Jutho Sep 27, 2025
8bd3d21
Fix small typos
lkdvos Sep 27, 2025
a5303da
fix svd_trunc_pullback and add tests
Jutho Sep 27, 2025
bf063b5
fix and test eig pullback, including trunc alternative
Jutho Sep 28, 2025
005af6b
fix rank edge case
lkdvos Sep 28, 2025
61ad8b7
default value of `ind` is untruncated
lkdvos Sep 28, 2025
9a763af
update docstrings
lkdvos Sep 28, 2025
f76ef53
remove some allocations
lkdvos Sep 29, 2025
ab08956
mark pullbacks as public
lkdvos Sep 29, 2025
5f12418
Bump v0.4.1
lkdvos Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pullbacks/svd.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function svd_pullback!(
minmn = min(m, n)
S = diagview(Smat)
length(S) == minmn || throw(DimensionMismatch())
r = findlast(>=(rank_atol), S) # rank
r = searchsortedlast(S, tol; rev = true) # rank
Comment thread
lkdvos marked this conversation as resolved.
Ur = view(U, :, 1:r)
Vᴴr = view(Vᴴ, 1:r, :)
Sr = view(S, 1:r)
Expand Down