Remove condition_number

Author: leburgel

src/algorithms/ctmrg/c4v.jl

@@ -146,7 +146,7 @@ function ctmrg_iteration(
     corner′, projector, info = c4v_projector!(enlarged_corner, alg.projector_alg)
     edge′ = c4v_renormalize_edge(network, env, projector)
     info = (;
-        contraction_metrics = (; info.truncation_error, info.condition_number),
+        contraction_metrics = (; info.truncation_error),
         info.D, info.V,
     )
     return CTMRGEnv(corner′, edge′), info
@@ -196,11 +196,6 @@ function c4v_projector!(enlarged_corner, alg::C4vEighProjector)
 
     D, V, truncation_error = eigh_trunc!(enlarged_corner, eigh_alg)
 
-    # get some decomposition info
-    condition_number = ignore_derivatives() do
-        return cond(D)
-    end
-
     # Check for degenerate eigenvalues
     Zygote.isderiving() && ignore_derivatives() do
         if alg.verbosity > 0 && is_degenerate_spectrum(D)
@@ -209,7 +204,7 @@ function c4v_projector!(enlarged_corner, alg::C4vEighProjector)
         end
     end
 
-    return D / norm(D), V, (; D, V, truncation_error, condition_number)
+    return D / norm(D), V, (; D, V, truncation_error)
 end
 """
     c4v_projector!(enlarged_corner, alg::C4vQRProjector)
@@ -225,7 +220,7 @@ Compute the C₄ᵥ projector by decomposing the column-enlarged corner with `le
 function c4v_projector!(enlarged_corner, alg::C4vQRProjector)
     Q, R = left_orth!(enlarged_corner, decomposition_algorithm(alg))
     # TODO: what's a meaningful way to compute a truncation error/condition number in this scheme?
-    return Q, (; Q, R, truncation_error = zero(scalartype(Q)), condition_number = 0)
+    return Q, (; Q, R, truncation_error = zero(scalartype(Q)))
 end
 
 """

src/algorithms/ctmrg/projectors.jl

@@ -171,9 +171,6 @@ function compute_projector(enlarged_corners, alg::HalfInfiniteProjector)
 
     # get some decomposition info
     truncation_error = truncation_error / norm(S) # normalize truncation error
-    condition_number = ignore_derivatives() do
-        return cond(S)
-    end
 
     # Check for degenerate singular values
     Zygote.isderiving() && ignore_derivatives() do
@@ -184,7 +181,7 @@ function compute_projector(enlarged_corners, alg::HalfInfiniteProjector)
     end
 
     P_left, P_right = contract_projectors(U, S, V, enlarged_corners...)
-    return (P_left, P_right), (; U, S, V, truncation_error, condition_number)
+    return (P_left, P_right), (; U, S, V, truncation_error)
 end
 function compute_projector(enlarged_corners, alg::FullInfiniteProjector)
     halfinf_left = half_infinite_environment(enlarged_corners[1], enlarged_corners[2])
@@ -197,9 +194,6 @@ function compute_projector(enlarged_corners, alg::FullInfiniteProjector)
 
     # get some decomposition info
     truncation_error = truncation_error / norm(S) # normalize truncation error
-    condition_number = ignore_derivatives() do
-        return cond(S)
-    end
 
     # Check for degenerate singular values
     Zygote.isderiving() && ignore_derivatives() do
@@ -210,5 +204,5 @@ function compute_projector(enlarged_corners, alg::FullInfiniteProjector)
     end
 
     P_left, P_right = contract_projectors(U, S, V, halfinf_left, halfinf_right)
-    return (P_left, P_right), (; U, S, V, truncation_error, condition_number)
+    return (P_left, P_right), (; U, S, V, truncation_error)
 end

src/algorithms/ctmrg/sequential.jl

@@ -59,17 +59,15 @@ end
 
 function ctmrg_iteration(network, env::CTMRGEnv, alg::SequentialCTMRG)
     truncation_error = zero(real(scalartype(network)))
-    condition_number = zero(real(scalartype(network)))
     for _ in 1:4 # rotate
         for col in 1:size(network, 2) # left move column-wise
             env, info = ctmrg_leftmove(col, network, env, alg)
             truncation_error = max(truncation_error, info.truncation_error)
-            condition_number = max(condition_number, info.condition_number)
         end
         network = rotate_north(network, EAST)
         env = rotate_north(env, EAST)
     end
-    return env, (; contraction_metrics = (; truncation_error, condition_number))
+    return env, (; contraction_metrics = (; truncation_error))
 end
 
 """

src/algorithms/ctmrg/simultaneous.jl

@@ -49,7 +49,7 @@ function ctmrg_iteration(network, env::CTMRGEnv, alg::SimultaneousCTMRG)
     projectors, info = simultaneous_projectors(enlarged_corners, env, alg.projector_alg)  # compute projectors on all coordinates
     env′ = renormalize_simultaneously(enlarged_corners, projectors, network, env)  # renormalize enlarged corners
     info = (;
-        contraction_metrics = (; info.truncation_error, info.condition_number),
+        contraction_metrics = (; info.truncation_error),
         info.U, info.S, info.V,
     )
     return env′, info
@@ -61,11 +61,10 @@ function _split_proj_and_info(proj_and_info)
     P_left = map(x -> x[1][1], proj_and_info)
     P_right = map(x -> x[1][2], proj_and_info)
     truncation_error = maximum(x -> x[2].truncation_error, proj_and_info)
-    condition_number = maximum(x -> x[2].condition_number, proj_and_info)
     U = map(x -> x[2].U, proj_and_info)
     S = map(x -> x[2].S, proj_and_info)
     V = map(x -> x[2].V, proj_and_info)
-    info = (; truncation_error, condition_number, U, S, V)
+    info = (; truncation_error, U, S, V)
     return (P_left, P_right), info
 end