Remove unused LinearAlgebra method implementations (#307)

* Remove unused LinearAlgebra method implementations

* Update changelog

Author: leburgel

Project.toml

@@ -38,7 +38,7 @@ MPSKit = "0.13.7"
 MPSKitModels = "0.4"
 MatrixAlgebraKit = "0.5.0"
 OhMyThreads = "0.7, 0.8"
-OptimKit = "0.3, 0.4"
+OptimKit = "0.4"
 Printf = "1"
 QuadGK = "2.11.1"
 Random = "1"

docs/src/changelog.md

@@ -24,10 +24,14 @@ When releasing a new version, move the "Unreleased" changes to a new version sec
 
 ### Changed
 
+- Bump OptimKit.jl compatibility to v0.4
+
 ### Deprecated
 
 ### Removed
 
+- Unused implementations of `LinearAlgebra` methods for `CTRMGEnv` and `InfinitePEPS`
+
 ### Fixed
 
 ### Performance

src/environments/ctmrg_environments.jl

@@ -341,34 +341,6 @@ end
 Base.:*(α::Number, e::CTMRGEnv) = CTMRGEnv(α * e.corners, α * e.edges)
 Base.similar(e::CTMRGEnv) = CTMRGEnv(similar(e.corners), similar(e.edges))
 
-function LinearAlgebra.mul!(edst::CTMRGEnv, esrc::CTMRGEnv, α::Number)
-    edst.corners .= α * esrc.corners
-    edst.edges .= α * esrc.edges
-    return edst
-end
-
-function LinearAlgebra.rmul!(e::CTMRGEnv, α::Number)
-    rmul!.(e.corners, α)
-    rmul!.(e.edges, α)
-    return e
-end
-
-function LinearAlgebra.axpy!(α::Number, e₁::CTMRGEnv, e₂::CTMRGEnv)
-    axpy!.(α, e₁.corners, e₂.corners)
-    axpy!.(α, e₁.edges, e₂.edges)
-    return e₂
-end
-
-function LinearAlgebra.axpby!(α::Number, e₁::CTMRGEnv, β::Number, e₂::CTMRGEnv)
-    e₂.corners .= α * e₁.corners + β * e₂.corners
-    e₂.edges .= α * e₁.edges + β * e₂.edges
-    return e₂
-end
-
-function LinearAlgebra.dot(e₁::CTMRGEnv, e₂::CTMRGEnv)
-    return dot(e₁.corners, e₂.corners) + dot(e₁.edges, e₂.edges)
-end
-
 # VectorInterface
 # ---------------
 

src/states/infinitepeps.jl

@@ -227,17 +227,6 @@ Base.rotl90(A::InfinitePEPS) = InfinitePEPS(rotl90(rotl90.(unitcell(A))))
 Base.rotr90(A::InfinitePEPS) = InfinitePEPS(rotr90(rotr90.(unitcell(A))))
 Base.rot180(A::InfinitePEPS) = InfinitePEPS(rot180(rot180.(unitcell(A))))
 
-## OptimKit optimization backwards compatibility (v0.4 uses VectorInterface)
-
-function LinearAlgebra.rmul!(A::InfinitePEPS, α::Number) # Used in _scale during OptimKit.optimize
-    rmul!.(unitcell(A), α)
-    return A
-end
-function LinearAlgebra.axpy!(α::Number, A₁::InfinitePEPS, A₂::InfinitePEPS) # Used in _add during OptimKit.optimize
-    axpy!.(α, unitcell(A₁), unitcell(A₂))
-    return A₂
-end
-
 ## FiniteDifferences vectorization
 
 """