Refactor :tsvd -> :full and SVDAdjoint{F,R,B} -> SVDAdjoint{F,R}

Author: pbrehmer

src/PEPSKit.jl

@@ -71,7 +71,7 @@ include("algorithms/select_algorithm.jl")
 
 using .Defaults: set_scheduler!
 export set_scheduler!
-export SVDAdjoint, IterSVD
+export SVDAdjoint, FullReverse, IterSVD
 export CTMRGEnv, SequentialCTMRG, SimultaneousCTMRG
 export FixedSpaceTruncation, HalfInfiniteProjector, FullInfiniteProjector
 export LocalOperator

src/algorithms/ctmrg/projectors.jl

@@ -58,7 +58,6 @@ function svd_algorithm(alg::ProjectorAlgorithm, (dir, r, c))
         return SVDAdjoint(;
             fwd_alg=fix_svd,
             rrule_alg=alg.svd_alg.rrule_alg,
-            broadening=alg.svd_alg.broadening,
         )
     else
         return alg.svd_alg

src/algorithms/optimization/fixed_point_differentiation.jl

@@ -263,7 +263,6 @@ function _fix_svd_algorithm(alg::SVDAdjoint, signs, info)
     return SVDAdjoint(;
         fwd_alg=FixedSVD(U_fixed, info.S, V_fixed, U_full_fixed, info.S_full, V_full_fixed),
         rrule_alg=alg.rrule_alg,
-        broadening=alg.broadening,
     )
 end
 function _fix_svd_algorithm(alg::SVDAdjoint{F}, signs, info) where {F<:IterSVD}
@@ -272,7 +271,6 @@ function _fix_svd_algorithm(alg::SVDAdjoint{F}, signs, info) where {F<:IterSVD}
     return SVDAdjoint(;
         fwd_alg=FixedSVD(U_fixed, info.S, V_fixed, nothing, nothing, nothing),
         rrule_alg=alg.rrule_alg,
-        broadening=alg.broadening,
     )
 end
 

test/examples/heisenberg.jl

@@ -93,7 +93,7 @@ end
         peps,
         env;
         optimizer_alg=(; tol=gradtol, maxiter=25),
-        boundary_alg=(; maxiter=150, svd_alg=(; rrule_alg=(; alg=:tsvd, tol=1e-5))),
+        boundary_alg=(; maxiter=150, svd_alg=(; rrule_alg=(; alg=:full, tol=1e-5))),
     )  # sensitivity warnings and degeneracies due to SU(2)?
     ξ_h, ξ_v, = correlation_length(peps_final, env_final)
     e_site2 = E_final / (N1 * N2)

test/gradients/ctmrg_gradients.jl

@@ -20,7 +20,7 @@ gradtol = 1e-4
 ctmrg_verbosity = 0
 ctmrg_algs = [[:sequential, :simultaneous], [:sequential, :simultaneous]]
 projector_algs = [[:halfinfinite, :fullinfinite], [:halfinfinite, :fullinfinite]]
-svd_rrule_algs = [[:tsvd, :arnoldi], [:tsvd, :arnoldi]]
+svd_rrule_algs = [[:full, :arnoldi], [:full, :arnoldi]]
 gradient_algs = [
     [nothing, :geomsum, :manualiter, :linsolver, :eigsolver],
     [:geomsum, :manualiter, :linsolver, :eigsolver],
@@ -29,9 +29,9 @@ gradient_iterschemes = [[:fixed, :diffgauge], [:fixed, :diffgauge]]
 steps = -0.01:0.005:0.01
 
 naive_gradient_combinations = [
-    (:simultaneous, :halfinfinite, :tsvd),
-    (:simultaneous, :fullinfinite, :tsvd),
-    (:sequential, :halfinfinite, :tsvd),
+    (:simultaneous, :halfinfinite, :full),
+    (:simultaneous, :fullinfinite, :full),
+    (:sequential, :halfinfinite, :full),
 ]
 naive_gradient_done = Set()
 

test/utility/svd_wrapper.jl

@@ -23,7 +23,7 @@ r = randn(dtype, ℂ^m, ℂ^n)
 R = randn(space(r))
 broadenings = [10.0^k for k in -16:-4]
 
-full_alg = SVDAdjoint(; rrule_alg=(; alg=:tsvd), broadening=0)
+full_alg = SVDAdjoint(; rrule_alg=(; alg=:full, broadening=0))
 iter_alg = SVDAdjoint(; fwd_alg=(; alg=:iterative))
 
 @testset "Non-truncacted SVD" begin
@@ -43,7 +43,7 @@ end
 end
 
 @testset "Truncated SVD with χ=$χ and ε=$ε broadening" for ε in broadenings
-    broadened_alg = @set full_alg.broadening = ε
+    broadened_alg = @set full_alg.rrule_alg.broadening = ε
     l_unbroadened, g_unbroadened = withgradient(A -> lossfun(A, full_alg, R, trunc), r)
     l_broadened, g_broadened = withgradient(A -> lossfun(A, broadened_alg, R, trunc), r)
 
@@ -81,7 +81,7 @@ symm_R = randn(dtype, space(symm_r))
 end
 
 @testset "Truncated symmetric SVD with χ=$χ and ε=$ε broadening" for ε in broadenings
-    broadened_alg = @set full_alg.broadening = ε
+    broadened_alg = @set full_alg.rrule_alg.broadening = ε
     l_unbroadened, g_unbroadened = withgradient(
         A -> lossfun(A, full_alg, symm_R, symm_trspace), symm_r
     )