Skip to content

Clean up and simplify optimization interface #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbrehmer merged 29 commits into from
Feb 11, 2025
Merged

Clean up and simplify optimization interface #127

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6211f4d
Update PEPSKit.Defaults
pbrehmer Feb 4, 2025
1916e2b
Break up peps_opt.jl into two files
pbrehmer Feb 4, 2025
c4e0436
Add symmetrization to PEPSOptimize
pbrehmer Feb 4, 2025
ab794ba
Fix realness warning in fixedpoint
pbrehmer Feb 4, 2025
42766e3
Rename `costfun` to `cost_function` and add docstring
pbrehmer Feb 5, 2025
9afaf5f
Clean up tests
pbrehmer Feb 5, 2025
dba99e4
Make PEPSKit.fixedpoint argument order consistent with MPSKit.fixedpo…
pbrehmer Feb 5, 2025
80f003d
Add truncation_error and condition_number to CTMRG info return tuples
pbrehmer Feb 5, 2025
6a8e739
Adapt leading_boundary calls to additional info return value
pbrehmer Feb 5, 2025
31e32bd
Adapt leading_boundary rrule to info tuple
pbrehmer Feb 5, 2025
ba17a81
Make changes runnable
pbrehmer Feb 6, 2025
3adbc67
Merge branch 'master' into pb-clean-opt-interface
pbrehmer Feb 6, 2025
3dc602f
Add collection of truncation errors, condition numbers, etc. during o…
pbrehmer Feb 6, 2025
e773be5
Adapt tests and examples to new fixedpoint return values
pbrehmer Feb 6, 2025
a027a3f
Fix tests (1st try)
pbrehmer Feb 6, 2025
799d9e8
Fix tests (2nd try)
pbrehmer Feb 6, 2025
a5c5e2a
Apply suggestions
pbrehmer Feb 7, 2025
3bad3da
Rename `envs` to `env`
pbrehmer Feb 7, 2025
1267077
Backpropagate _condition_number with ZeroTangent
pbrehmer Feb 7, 2025
d4c620b
Update src/algorithms/ctmrg/simultaneous.jl
pbrehmer Feb 7, 2025
8c93c6e
Relocate computation of condition to projectors
pbrehmer Feb 7, 2025
38d42ac
Merge branch 'pb-clean-opt-interface' of github.com:quantumghent/PEPS…
pbrehmer Feb 7, 2025
58b4570
Use `@ignore_derivatives` for _condition_number
pbrehmer Feb 7, 2025
bf09931
Apply local info suggestion
pbrehmer Feb 7, 2025
6afe263
Replace Zygote.Buffers in CTMRG
pbrehmer Feb 10, 2025
534e6f9
Merge branch 'pb-clean-opt-interface' of github.com:quantumghent/PEPS…
pbrehmer Feb 10, 2025
ea46eb2
Fix condition number computation
pbrehmer Feb 10, 2025
7d4f51f
Fix _condition_number
pbrehmer Feb 10, 2025
e7077a3
Compose first and last directly
pbrehmer Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/algorithms/ctmrg/simultaneous.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ function _condition_number(S::AbstractTensorMap)
return maximum(b_diag) / minimum(b_diag)
end
end
@non_differentiable _condition_number(S::AbstractTensorMap)
function ChainRulesCore.rrule(::typeof(_condition_number), S::AbstractTensorMap) # Backpropagte with ZeroTangent() as work-around
condition_number = _condition_number(S)
_condition_number_pullback(_) = (NoTangent(), ZeroTangent())
return condition_number, _condition_number_pullback
Copy link
Copy Markdown
Member

@lkdvos lkdvos Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
condition_number = _condition_number(S)
_condition_number_pullback(_) = (NoTangent(), ZeroTangent())
return condition_number, _condition_number_pullback
return _condition_number(S), Returns((NoTangent(), ZeroTangent()))

end

"""
simultaneous_projectors(enlarged_corners::Array{E,3}, env::CTMRGEnv, alg::ProjectorAlgorithm)
Expand Down