Update info in leading_boundary output for CTMRG#365
Merged
Conversation
Yue-Zhengyuan
approved these changes
Apr 22, 2026
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Member
Author
|
What do you think about removing the decompositions from the info output of |
Collaborator
|
Sorry, I somehow missed this review request. I think removing the decompositions from the |
pbrehmer
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #354. Changes the contents of the
infonamed tuple returned by the CTMRGleading_boundaryto now include:info.converged::Bool: Boolean flag indicating whether or not theleading_boundaryrun converged to the requestedtolwithin the specifiedmaxiter.info.convergence_error::Real: Convergence error after the final iteration of theleading_boundaryrun.In addition, I would suggest we remove the intermediate objects used in the contraction algorithm (
U/S/Vfor asymmetric CTMRG,V/Dfor eigh-C4vCTMRG,Q/Rfor QR-C4vCTMRG from the outputinfo. This is all extremely specific to the algorithm being used, and as far as I can tell this output is never actually used. I left in thecontraction_metricsfield, since these metrics do seem useful.The only place where this output is used is in the
inforeturned by a singlectmrg_iteration(specifically for gauge fixing). That makes much more sense to me, since these decompositions are really intermediate objects in a single iteration. So it makes sense to keep them there. Let me know what you think about removing the decompositions from theinfooutput ofleading_boundary@pbrehmer.