Improve efficiency of bond truncation#366
Merged
lkdvos merged 8 commits intoQuantumKitHub:masterfrom Apr 29, 2026
Merged
Conversation
Member
Author
|
@sanderdemeyer I recommend you (squash-)merge this PR to the NTU branch (#144) when trying it. |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
leburgel
approved these changes
Apr 28, 2026
Member
Author
|
I dropped the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the efficiency of
bond_truncate(for bothALSTruncationandFullEnvTruncation) by reusing intermediate partial contraction results.The test
test/bondenv/bond_truncate.jlis rewritten to simulate the more realistic scenario of applying a 2-site gate on an iPEPS with physical dimensiondand virtual dimensionD. It can reveal that FET is much slower whendis large (due to physical leg not transferred to the reduced bond tensors to be optimized).