Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 39 files with indirect coverage changes 🚀 New features to boost your workflow:
|
leburgel
approved these changes
May 5, 2026
Member
leburgel
left a comment
There was a problem hiding this comment.
Thanks for sorting this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into some problems with the latest MPSKit version (current main branch) and the boundary MPS code which was caused by the addition of a
prepare::Boolkeyword argument, which then bypassed our specializations.This is a backwards and forwards compatible fix that resolves this.
Tested this locally against the latest MPSKit version, but wanted to resolve this before releasing another MPSKit version, hence the fix here.
Thanks to @leburgel for reporting!