Skip to content

ensure MPSKit overloads take all keywords#374

Merged
lkdvos merged 1 commit into
masterfrom
mpskit
May 5, 2026
Merged

ensure MPSKit overloads take all keywords#374
lkdvos merged 1 commit into
masterfrom
mpskit

Conversation

@lkdvos
Copy link
Copy Markdown
Member

@lkdvos lkdvos commented May 4, 2026

Ran into some problems with the latest MPSKit version (current main branch) and the boundary MPS code which was caused by the addition of a prepare::Bool keyword argument, which then bypassed our specializations.
This is a backwards and forwards compatible fix that resolves this.

Tested this locally against the latest MPSKit version, but wanted to resolve this before releasing another MPSKit version, hence the fix here.

Thanks to @leburgel for reporting!

@lkdvos lkdvos requested a review from leburgel May 4, 2026 20:58
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/algorithms/contractions/vumps_contractions.jl 81.44% <100.00%> (-3.10%) ⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@leburgel leburgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out!

@lkdvos lkdvos merged commit 3b66c3a into master May 5, 2026
65 checks passed
@lkdvos lkdvos deleted the mpskit branch May 5, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants