Updates for TensorKit fusiontree vectorization#49
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
borisdevos
reviewed
May 28, 2026
borisdevos
left a comment
borisdevos
left a comment
Member
There was a problem hiding this comment.
A small nitpick comment, but looks otherwise good!
borisdevos
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed some of the tests here to use the new
FusionTreeBlocklayout and more closely follow the TensorKit fusiontree tests. Not all of the tests survived, but I think (or assume) that some of them were also here historically to test the TensorKit multiplicity implementation, so I would be fine with no longer testing that part so well. In principle, we are now more sure of our interface (see also #44), so it shouldn't even be necessary to test the interaction with the fusiontrees.