Refactor _step_hotrg(3d)_x(y)#107
Conversation
|
@VictorVanthilt I now tend to believe that the macOS test failure (again on the accuracy of Ising scaling dimension) is caused by Julia 1.12. Maybe you can follow other QuantumKitHub packages to set up test with the LTS version (currently it is 1.10.10) of Julia? |
|
We had issues like this before, where mac os was actually the only one not failing. There is some difference in between apple silicon and intel/amd chips when it comes to floating point arithmetic. Previously it was showing up because we were dividing really small (on the order of machine precision) numbers. I will add testing with LTS to the test suite to check if it is indeed a julia 1.12 issue. |
|
Before that let's refrain from merging |
|
I think this |
|
Can you merge the TNRKit master branch into this one, then I can merge this. |
|
Considering @Adwait-Naravane's comment, should we rename BTRG to BwTRG to avoid ambiguity? (Bond-weighted vs boundary) |
|
The Boundary TRG paper was first (2019) at calling their method BTRG, the Bond-weighted TRG paper also calls their method BTRG but only did so in 2020. So @dartsushi, what do you think?
For now keeping |
|
I believe people refer to Bond-weighted TRG as BTRG more often nowadays. I would like to call this the other as BoundaryTRG and keep BTRG as it is |
|
Okay thanks! |
This PR refactors the functions
_step_hotrg(3d)_x(y)by moving the part to find the projectors out of them, so they can be reused by impurity HOTRG (motivated by #105).