Skip to content

Impurity TRG#111

Merged
VictorVanthilt merged 28 commits intoQuantumKitHub:masterfrom
JaridPiceu:ImpurityTRG
Oct 20, 2025
Merged

Impurity TRG#111
VictorVanthilt merged 28 commits intoQuantumKitHub:masterfrom
JaridPiceu:ImpurityTRG

Conversation

@JaridPiceu
Copy link
Copy Markdown
Contributor

🚀 This PR adds Impurity TRG to TNRKit.

Additions

  • New scheme: ImpurityTRG
  • Corresponding finalize function
  • Tests for the new scheme

Others

  • The naming, tests, and structure largely follow Impurity HOTRG #105 and earlier implementations for consistency.
  • Formatted with Runic.

All nicely renormalized and ready to flow. ✨

@VictorVanthilt VictorVanthilt self-requested a review October 19, 2025 08:54
Copy link
Copy Markdown
Member

@VictorVanthilt VictorVanthilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some small comments

Comment thread src/schemes/impuritytrg.jl Outdated
Comment thread test/schemes.jl Outdated
Comment thread test/schemes.jl Outdated
Comment thread src/schemes/impuritytrg.jl Outdated
Comment thread src/schemes/impuritytrg.jl Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 19, 2025

Your PR no longer requires formatting changes. Thank you for your contribution!

Copy link
Copy Markdown
Member

@VictorVanthilt VictorVanthilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small suggestions that you can just press commit on.

Also added a small request for an extra test

Comment thread src/schemes/impuritytrg.jl Outdated
Comment thread src/TNRKit.jl Outdated
Comment thread src/TNRKit.jl
Comment thread src/TNRKit.jl Outdated
Comment thread src/TNRKit.jl
Comment thread test/schemes.jl
JaridPiceu and others added 9 commits October 20, 2025 15:11
Co-authored-by: Victor Vanthilt <73738005+VictorVanthilt@users.noreply.github.com>
Co-authored-by: Victor Vanthilt <73738005+VictorVanthilt@users.noreply.github.com>
Co-authored-by: Victor Vanthilt <73738005+VictorVanthilt@users.noreply.github.com>
Co-authored-by: Victor Vanthilt <73738005+VictorVanthilt@users.noreply.github.com>
Co-authored-by: Victor Vanthilt <73738005+VictorVanthilt@users.noreply.github.com>
@VictorVanthilt VictorVanthilt self-requested a review October 20, 2025 15:50
@VictorVanthilt VictorVanthilt merged commit fc0e378 into QuantumKitHub:master Oct 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants