Apply suggestions from code review

Co-authored-by: Lukas Devos <ldevos98@gmail.com>

Author: kshyatt

ext/TensorKitAdaptExt.jl

@@ -16,7 +16,8 @@ function Adapt.adapt_structure(to, x::DiagonalTensorMap)
     return DiagonalTensorMap(data′, x.domain)
 end
 function Adapt.adapt_structure(::Type{T}, x::BraidingTensor{T′, S, A}) where {T <: Number, T′, S, A}
-    return BraidingTensor{T}(space(x), x.adjoint)
+    A = TensorKit.similarstoragetype(A, T)
+    return BraidingTensor{T, S, A}(space(x), x.adjoint)
 end
 function Adapt.adapt_structure(::Type{TA}, x::BraidingTensor{T, S, A}) where {T′, TA <: DenseArray{T′}, T, S, A}
     return BraidingTensor{T′, S, TA}(space(x), x.adjoint)

src/tensors/braidingtensor.jl

@@ -2,7 +2,7 @@
 # special (2,2) tensor that implements a standard braiding operation
 #====================================================================#
 """
-    struct BraidingTensor{T,S<:IndexSpace,A<:DenseVector{T}} <: AbstractTensorMap{T, S, 2, 2}
+    struct BraidingTensor{T, S <: IndexSpace, A <: DenseVector{T}} <: AbstractTensorMap{T, S, 2, 2}
     BraidingTensor(V1::S, V2::S, adjoint::Bool=false) where {S<:IndexSpace}
     BraidingTensor{T, S, A}(V1::S, V2::S, adjoint::Bool=false) where {T, S, A}
 
@@ -14,7 +14,7 @@ It holds that `domain(BraidingTensor(V1, V2)) == V1 ⊗ V2` and
 controls the array type of the braiding tensor used when indexing
 and multiplying with other tensors.
 """
-struct BraidingTensor{T, S, A} <: AbstractTensorMap{T, S, 2, 2}
+struct BraidingTensor{T, S, A <: DenseVector{T}} <: AbstractTensorMap{T, S, 2, 2}
     V1::S
     V2::S
     adjoint::Bool
@@ -133,8 +133,7 @@ end
     data_parent = storagetype(b)(undef, prod(d))
     data = sreshape(StridedView(data_parent), d)
     r = _braiding_factor(f₁, f₂, b.adjoint)
-    val = isnothing(r) ? zero(eltype(b)) : r
-    fill_braidingsubblock!(data, val)
+    isnothing(r) ? zerovector!(data) : fill_braidingsubblock!(data, r)
     return data
 end
 
@@ -171,8 +170,7 @@ function fill_braidingblock!(data, b::BraidingTensor, s::Sector)
         subblock = StridedView(data, sz, str, off - base_offset)
         # without the zero-value, the non-trivial block is not set
         # correctly in the GPU case
-        val = isnothing(r) ? zero(eltype(data)) : r
-        fill_braidingsubblock!(subblock, val)
+        isnothing(r) ? zerovector!(subblock) : fill_braidingsubblock!(subblock, r)
     end
     return data
 end

test/setup.jl

@@ -115,7 +115,7 @@ function force_planar(tsrc::TensorMap{<:Any, ComplexSpace})
         undef,
         force_planar(codomain(tsrc)) ←
             force_planar(domain(tsrc))
-    )
+    tdst = similar(tsrc, force_planar(codomain(tsrc)) ← force_planar(domain(tsrc)))
     copyto!(block(tdst, PlanarTrivial()), block(tsrc, Trivial()))
     return tdst
 end
@@ -124,7 +124,7 @@ function force_planar(tsrc::TensorMap{<:Any, <:GradedSpace})
         undef,
         force_planar(codomain(tsrc)) ←
             force_planar(domain(tsrc))
-    )
+    tdst = similar(tsrc, force_planar(codomain(tsrc)) ← force_planar(domain(tsrc)))
     for (c, b) in blocks(tsrc)
         copyto!(block(tdst, c ⊠ PlanarTrivial()), b)
     end